Paths

Table of Contentst

Implement native wrapper for syncPlatformDetails RPC
ClosedPublic
Actions

Authored by marcin on Jun 4 2024, 6:26 AM.

Details

Reviewers

kamil
bartek

Commits

rCOMM54e4b16d2f01: Implement native wrapper for syncPlatformDetails RPC

Summary

This differential implements native client wrapper over new RPC to sync platform details.

Test Plan

Build native app and log-in
Re-build native app with changed PLATFORM_METADATA constants.
Run the app calling commRustModule.syncPlatformDetails() in some React.useEffect().
Ensure in dynamodb admin that change occured.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Jun 4 2024, 6:26 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 4 2024, 6:26 AM

marcin added a child revision: D12311: Expose syncing platform details to identity client context.Jun 4 2024, 6:45 AM

marcin added a parent revision: D12308: Enable the client to fetch users platform details from identity RPC.

Harbormaster completed remote builds in B29438: Diff 40953.Jun 4 2024, 6:59 AM

marcin requested review of this revision.Jun 4 2024, 6:59 AM

bartek accepted this revision.Jun 4 2024, 8:00 AM

This revision is now accepted and ready to land.Jun 4 2024, 8:00 AM

Rebase befoe landing

Harbormaster completed remote builds in B29492: Diff 41057.Jun 6 2024, 8:42 AM

Closed by commit rCOMM54e4b16d2f01: Implement native wrapper for syncPlatformDetails RPC (authored by marcin). · Explain WhyJun 6 2024, 8:59 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM54e4b16d2f01: Implement native wrapper for syncPlatformDetails RPC.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommRustModule.h

5 lines

CommRustModule.cpp

26 lines

_generated/

rustJSI-generated.cpp

rustJSI.h

native_rust_library/

src/

identity/

device_list.rs

35 lines

lib.rs

8 lines

schema/

CommRustModuleSchema.js

5 lines

Diff 41062

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

View Options

native/cpp/CommonCpp/_generated/rustJSI.h

View Options

native/native_rust_library/src/identity/device_list.rs

View Options

native/native_rust_library/src/lib.rs

View Options

native/schema/CommRustModuleSchema.js

Implement native wrapper for syncPlatformDetails RPCClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41062

native/cpp/CommonCpp/NativeModules/CommRustModule.h

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

native/cpp/CommonCpp/_generated/rustJSI.h

native/native_rust_library/src/identity/device_list.rs

native/native_rust_library/src/lib.rs

native/schema/CommRustModuleSchema.js

Implement native wrapper for syncPlatformDetails RPC
ClosedPublic
Actions

Revision Contents
Changeset List