Page MenuHomePhabricator

[identity] Add metadata parser for PlatformDetails
ClosedPublic

Authored by bartek on Jun 3 2024, 4:10 AM.
Tags
None
Referenced Files
F2191242: D12270.id.diff
Thu, Jul 4, 2:36 PM
Unknown Object (File)
Thu, Jun 27, 5:22 AM
Unknown Object (File)
Sun, Jun 23, 5:35 PM
Unknown Object (File)
Sat, Jun 22, 10:29 PM
Unknown Object (File)
Sat, Jun 22, 7:28 PM
Unknown Object (File)
Fri, Jun 21, 6:28 PM
Unknown Object (File)
Fri, Jun 21, 2:28 PM
Unknown Object (File)
Fri, Jun 21, 12:25 PM
Subscribers

Details

Summary

Reasoning in D12269 - we want to pass full PlatformDetails with Identity requests metadata, not only platform and code version.

Decided to introduce PlatformMetadata struct which accepts device type as string.
This is needed for custom device types (like "service") which are valid identity clients, but not valid devices for registration.
Parsing is handled in the next diff

Depends on D12269

Test Plan
  • Modified web client to introduce additional metadata in CodeVersionLayer.
  • Verified that calling get_platform_metadata() retrieve these params.
  • Verified that None is returned for state version and desktop version when not provided.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable