Page MenuHomePhabricator
Differential D12315

[lib] Introduce `MemberInfoSansPermissions`
ClosedPublic
Actions

Authored by atul on Jun 4 2024, 2:29 PM.
Tags
None
Referenced Files
F2831249: D12315.diff
Fri, Sep 27, 11:14 PM
Unknown Object (File)
Wed, Sep 25, 10:49 PM
Unknown Object (File)
Wed, Sep 25, 10:49 PM
Unknown Object (File)
Wed, Sep 25, 10:49 PM
Unknown Object (File)
Mon, Sep 9, 9:07 AM
Unknown Object (File)
Mon, Sep 9, 9:07 AM
Unknown Object (File)
Mon, Sep 9, 8:52 AM
Unknown Object (File)
Fri, Aug 30, 10:17 PM
View All 60 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
varun
Commits
rCOMM9cc32873ab68: [lib] Introduce `MemberInfoSansPermissions`
Summary

Introduce MemberInfoSansPermissions, stripPermissionsFromMemberInfo, and some unit tests.

The type will eventually replace MemberInfoWithPermissions in RawThreadInfo, but for now it's convenient to use to "surface" flow issues.

Depends on D12296

Test Plan

flow + unit tests

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D12315 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 4 2024, 2:29 PM
atul added a comment.Jun 4 2024, 2:31 PM

This is really mostly for my convenience so I can avoid stashing/unstashing while working through remainder of stack until ready to replace MemberInfoWithPermissions with MemberInfoSansPermissions.

atul published this revision for review.Jun 4 2024, 2:31 PM
Harbormaster completed remote builds in B29445: Diff 40974.Jun 4 2024, 2:46 PM
tomek accepted this revision.Jun 5 2024, 2:30 AM
tomek added inline comments.
lib/types/minimally-encoded-thread-permissions-types.js
108–113 ↗(On Diff #40974)

How about using $Diff?

This revision is now accepted and ready to land.Jun 5 2024, 2:30 AM
tomek added inline comments.Jun 5 2024, 2:32 AM
lib/types/minimally-encoded-thread-permissions-types.js
108–113 ↗(On Diff #40974)

Or even $Rest https://flow.org/en/docs/types/utilities/#toc-rest which

is the type that represents the runtime object rest operation

ashoat accepted this revision.Jun 5 2024, 6:28 AM

Agree with @tomek's feedback

atul added a child revision: D12321: [lib] Add `MemberInfoSansPermissions` support to `threadOtherMembers`.Jun 5 2024, 2:42 PM
atul updated this revision to Diff 41423.Jun 17 2024, 5:42 PM

rebase before landing

atul updated this revision to Diff 41424.Jun 17 2024, 5:44 PM

use $Diff

Harbormaster completed remote builds in B29729: Diff 41423.Jun 17 2024, 5:59 PM
Harbormaster completed remote builds in B29730: Diff 41424.
Closed by commit rCOMM9cc32873ab68: [lib] Introduce `MemberInfoSansPermissions` (authored by atul). · Explain WhyJun 17 2024, 8:06 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM9cc32873ab68: [lib] Introduce `MemberInfoSansPermissions`.

Revision Contents
Changeset List

Diff 41424

View Options

lib/types/minimally-encoded-thread-permissions-types.js

Loading...
View Options

lib/types/minimally-encoded-thread-permissions-types.test.js

Loading...