Details

Reviewers

bartek
marcin
inka

Commits

rCOMM41d017de4cc6: [lib][web][native] add Tunnelbroker device token to redux

Summary

ENG-8400 and ENG-8348

Test Plan

Test migration

Diff Detail

Repository

rCOMM Comm

Branch

land-token

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jun 20 2024, 10:51 PM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 20 2024, 10:51 PM

rename

Harbormaster completed remote builds in B29850: Diff 41585.Jun 20 2024, 11:10 PM

kamil published this revision for review.Jun 20 2024, 11:13 PM

Harbormaster failed remote builds in B29849: Diff 41584!Jun 20 2024, 11:16 PM

inka added inline comments.Jun 21 2024, 7:33 AM

lib/reducers/tunnelbroker-device-token-reducer.js
7–12 ↗	(On Diff #41585)	I'm guessing this will be updated?
native/redux/persist.js
1424 ↗	(On Diff #41585)	Don't we want to update this?
web/redux/persist.js
571 ↗	(On Diff #41585)	Shouldn't we update `storeVersion`?

bump version

lib/reducers/tunnelbroker-device-token-reducer.js
7–12 ↗	(On Diff #41585)	sure, in next diffs
native/redux/persist.js
1424 ↗	(On Diff #41585)	yeah we want, forgot to commit that change, thanks for catching

Harbormaster completed remote builds in B29862: Diff 41597.Jun 21 2024, 8:36 AM

kamil added a child revision: D12536: [lib][web][native] set local Tunnelbroker device token on client.Jun 21 2024, 9:19 AM

inka accepted this revision.Jun 21 2024, 9:35 AM

This revision is now accepted and ready to land.Jun 21 2024, 9:35 AM

rebase

Harbormaster completed remote builds in B29999: Diff 41807.Jun 28 2024, 2:19 PM

Closed by commit rCOMM41d017de4cc6: [lib][web][native] add Tunnelbroker device token to redux. · Explain WhyJun 28 2024, 2:28 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM41d017de4cc6: [lib][web][native] add Tunnelbroker device token to redux.

[lib][web][native] add Tunnelbroker device token to redux
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 41807

lib/reducers/master-reducer.js

lib/reducers/tunnelbroker-device-token-reducer.js

lib/types/redux-types.js

lib/types/tunnelbroker-device-token-types.js

lib/utils/reducers-utils.test.js

native/redux/default-state.js

native/redux/persist.js

native/redux/state-types.js

web/redux/default-state.js

web/redux/handle-redux-migration-failure.js

web/redux/persist-constants.js

web/redux/persist.js

web/redux/redux-setup.js

[lib][web][native] add Tunnelbroker device token to reduxClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41807

lib/reducers/master-reducer.js

lib/reducers/tunnelbroker-device-token-reducer.js

lib/types/redux-types.js

lib/types/tunnelbroker-device-token-types.js

lib/utils/reducers-utils.test.js

native/redux/default-state.js

native/redux/persist.js

native/redux/state-types.js

web/redux/default-state.js

web/redux/handle-redux-migration-failure.js

web/redux/persist-constants.js

web/redux/persist.js

web/redux/redux-setup.js

[lib][web][native] add Tunnelbroker device token to redux
ClosedPublic
Actions

Revision Contents
Changeset List