[web] fix uncaught exception bug
ClosedPublic
Actions

Authored by varun on Jun 21 2024, 4:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 9, 6:48 AM

	Unknown Object (File)
	Thu, Nov 7, 10:09 PM

	Unknown Object (File)
	Sat, Nov 2, 4:32 AM

	Unknown Object (File)
	Fri, Oct 25, 1:15 AM

	Unknown Object (File)
	Thu, Oct 24, 6:30 PM

	Unknown Object (File)
	Fri, Oct 18, 4:33 PM

	Unknown Object (File)
	Oct 13 2024, 9:56 AM

	Unknown Object (File)
	Oct 12 2024, 9:26 PM

View All 88 Files

Subscribers

ashoat

tomek

Details

Reviewers

inka
ginsu

Commits

rCOMMb94eb9c9e71b: [web] fix uncaught exception bug

Summary

Depends on D12547

Looks like this bug was introduced in D11768. We don't need to re-throw here.

Test Plan

no longer getting an uncaught exception error when SIWE fails

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Jun 21 2024, 4:54 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 21 2024, 4:54 PM

varun added a child revision: D12549: [web] fix uncaught exception when user cancels SIWE.Jun 21 2024, 4:55 PM

Harbormaster completed remote builds in B29886: Diff 41630.Jun 21 2024, 5:10 PM

varun requested review of this revision.Jun 21 2024, 5:10 PM

inka accepted this revision.Jun 24 2024, 12:37 AM

This revision is now accepted and ready to land.Jun 24 2024, 12:37 AM

Closed by commit rCOMMb94eb9c9e71b: [web] fix uncaught exception bug (authored by varun). · Explain WhyJun 24 2024, 10:29 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMb94eb9c9e71b: [web] fix uncaught exception bug.

Revision Contents
Changeset List

Path

Size

web/

account/

siwe-login-form.react.js

3 lines

Diff 41630

View Options

web/account/siwe-login-form.react.js

[web] fix uncaught exception bugClosedPublicActions