Page MenuHomePhabricator

[native] Add dev-only button for primary device logout
ClosedPublic

Authored by bartek on Jun 28 2024, 2:15 AM.
Tags
None
Referenced Files
F3342014: D12604.diff
Fri, Nov 22, 12:12 AM
Unknown Object (File)
Mon, Nov 11, 8:56 PM
Unknown Object (File)
Mon, Nov 11, 5:23 PM
Unknown Object (File)
Mon, Nov 11, 9:08 AM
Unknown Object (File)
Mon, Nov 11, 8:04 AM
Unknown Object (File)
Wed, Nov 6, 2:51 PM
Unknown Object (File)
Sat, Nov 2, 12:43 AM
Unknown Object (File)
Fri, Oct 25, 5:47 PM
Subscribers

Details

Summary

Similarly to D12222, added a dev-only button to perform primary device logout on native. It doesn't make sense on web
because calling the hook there breaks invariant (identity client method undefined, web cannot be primary).

For now, leaving two separate buttons to be able to test checks at lower level (e.g. server-side). But finally,
this will get replaced with a single button that performs different action based on the device being primary or secondary.
This is tracked in ENG-8550.

Depends on D12603

Test Plan

Both buttons are displayed in Profile menu on simulator. Test plan for D12603 is repeated to test hook behavior.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Jul 1 2024, 12:06 AM
kamil added inline comments.
native/profile/profile-screen.react.js
387

can you link task which should address it (and link this diff in linear issue)?

This revision is now accepted and ready to land.Jul 1 2024, 3:19 AM
native/profile/profile-screen.react.js
387

Generally it's tracked in ENG-8550 where we merge two buttons into one, based on when it's primary or secondary device