Page MenuHomePhabricator
Differential D12608

[Tunnelbroker] add notifs module and needed crates
ClosedPublic
Actions

Authored by kamil on Fri, Jun 28, 4:16 AM.
Tags
None
Referenced Files
F2194199: D12608.id41785.diff
Fri, Jul 5, 2:22 AM
Unknown Object (File)
Wed, Jul 3, 11:24 PM
Unknown Object (File)
Tue, Jul 2, 9:20 PM
Unknown Object (File)
Tue, Jul 2, 2:21 PM
Unknown Object (File)
Tue, Jul 2, 5:31 AM
Unknown Object (File)
Tue, Jul 2, 5:28 AM
Unknown Object (File)
Sat, Jun 29, 12:47 AM
Unknown Object (File)
Sat, Jun 29, 12:47 AM
View All 9 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
marcin
Commits
rCOMMe72cabb4777b: [Tunnelbroker] add notifs module and needed crates
Summary

Dependencies are already used elsewhere in the codebase.

Making apns optional to allow running local TB without fully configured APNs service, but after this work is fully done, I plan to make it mandatory.

Depends on D12607

Test Plan

cargo check

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Fri, Jun 28, 4:16 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFri, Jun 28, 4:16 AM
kamil added a child revision: D12609: [Tunnelbroker] implement APNs config.Fri, Jun 28, 4:25 AM
Harbormaster completed remote builds in B29986: Diff 41785.Fri, Jun 28, 4:32 AM
kamil published this revision for review.Fri, Jun 28, 6:23 AM
kamil edited the summary of this revision. (Show Details)
marcin accepted this revision.Mon, Jul 1, 2:02 AM
This revision is now accepted and ready to land.Mon, Jul 1, 2:02 AM
marcin added inline comments.Mon, Jul 1, 2:03 AM
services/tunnelbroker/src/notifs/apns/mod.rs
4 ↗(On Diff #41785)

This flag must be false on staging.

kamil added inline comments.Tue, Jul 2, 4:06 AM
services/tunnelbroker/src/notifs/apns/mod.rs
4 ↗(On Diff #41785)

this flag will set be based on config - see D12609

Closed by commit rCOMMe72cabb4777b: [Tunnelbroker] add notifs module and needed crates (authored by kamil). · Explain WhyTue, Jul 2, 8:35 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMe72cabb4777b: [Tunnelbroker] add notifs module and needed crates.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
2 lines
src/
1 line
notifs/
apns/
5 lines
8 lines

Diff 41889

View Options

Cargo.lock

Loading...
View Options

services/tunnelbroker/Cargo.toml

Loading...
View Options

services/tunnelbroker/src/main.rs

Loading...
View Options

services/tunnelbroker/src/notifs/apns/mod.rs

Loading...
View Options

services/tunnelbroker/src/notifs/mod.rs

Loading...