Implementing building request headers.
Apple docs: Send a POST request to APNs.
Not sure about PushType - perhaps we can just use String but I prefer more detailed type definition. (cc. @marcin).
Depends on D12611
Details
Details
Tested calling this function with different params
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- apns-tb
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Rust looks ok, letting @marcin review as well, I have no context on some of these
| services/tunnelbroker/src/notifs/apns/mod.rs | ||
|---|---|---|
| 36–39 | Not sure about your preference, just indicating there's another way of doing this: impl TryFrom<NotificationHeaders> for HeaderMap { type Error = error::Error; fn try_from(notif_headers: NotificationHeaders) -> Result<Self, Self::Error> { // ... } } A good alternative if you feel impl APNsClient becomes bloated and difficult to navigate | |
| 71 | The push_type_str should be a &'static str so using HeaderValue::from_static() should be possible | |
| services/tunnelbroker/src/notifs/apns/mod.rs | ||
|---|---|---|
| 36–39 | I like this but this could get messy because of self.token.get_bearer().await? below | |