Page MenuHomePhabricator
Differential D12616

[Tunnelbroker] implement sending APNs notifs by client
ClosedPublic
Actions

Authored by kamil on Jun 28 2024, 5:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 11:13 AM
Unknown Object (File)
Fri, Mar 7, 1:42 AM
Unknown Object (File)
Fri, Mar 7, 1:36 AM
Unknown Object (File)
Thu, Mar 6, 1:31 PM
Unknown Object (File)
Feb 21 2025, 3:49 PM
Unknown Object (File)
Feb 19 2025, 6:51 PM
Unknown Object (File)
Feb 18 2025, 7:38 AM
Unknown Object (File)
Jan 23 2025, 2:27 AM
View All 81 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
marcin
Commits
rCOMMae75b01335c7: [Tunnelbroker] implement sending APNs notifs by client
Summary

Handle APNsNotif message from device

Depends on D12615

Test Plan

Tested in D12617.

Diff Detail

Repository
rCOMM Comm
Branch
land-apns
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jun 28 2024, 5:46 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 28 2024, 5:47 AM
kamil added a child revision: D12617: [lib] implement sending APNs notifs using Tunnelbroker.Jun 28 2024, 5:51 AM
kamil edited the test plan for this revision. (Show Details)Jun 28 2024, 5:52 AM
Harbormaster completed remote builds in B29995: Diff 41794.Jun 28 2024, 6:03 AM
kamil published this revision for review.Jun 28 2024, 6:34 AM
kamil added inline comments.
services/tunnelbroker/src/websockets/session.rs
403 ↗(On Diff #41794)
marcin accepted this revision.Jul 2 2024, 2:11 AM
This revision is now accepted and ready to land.Jul 2 2024, 2:11 AM
kamil updated this revision to Diff 41886.Jul 2 2024, 6:08 AM

use Some

Harbormaster completed remote builds in B30055: Diff 41886.Jul 2 2024, 6:23 AM
Closed by commit rCOMMae75b01335c7: [Tunnelbroker] implement sending APNs notifs by client (authored by kamil). · Explain WhyJul 2 2024, 8:35 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMae75b01335c7: [Tunnelbroker] implement sending APNs notifs by client.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
7 lines
notifs/
apns/
2 lines
websockets/
21 lines
72 lines

Diff 41886

View Options

services/tunnelbroker/src/main.rs

Show First 20 Lines • Show All 766 Lines • ▼ Show 20 Lines onConcludeEntryEditMode = (entryInfo: EntryInfoWithHeight) => {
} }
}; };
keyboardShow = (event: KeyboardEvent) => { keyboardShow = (event: KeyboardEvent) => {
// flatListHeight() factors in the size of the tab bar, // flatListHeight() factors in the size of the tab bar,
// but it is hidden by the keyboard since it is at the bottom // but it is hidden by the keyboard since it is at the bottom
const { bottomInset, tabBarHeight } = this.props.dimensions; const { bottomInset, tabBarHeight } = this.props.dimensions;
const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5; const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5;
const keyboardHeight = Platform.select({ const keyboardHeight: number = Platform.select({
// Android doesn't include the bottomInset in this height measurement // Android doesn't include the bottomInset in this height measurement
android: event.endCoordinates.height, android: event.endCoordinates.height,
default: Math.max(event.endCoordinates.height - bottomInset, 0), default: Math.max(event.endCoordinates.height - bottomInset, 0),
}); });
const keyboardShownHeight = const keyboardShownHeight =
inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0); inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0);
this.keyboardShownHeight = keyboardShownHeight; this.keyboardShownHeight = keyboardShownHeight;
▲ Show 20 Lines • Show All 332 Lines • Show Last 20 Lines
View Options

services/tunnelbroker/src/notifs/apns/mod.rs

Show First 20 Lines • Show All 766 Lines • ▼ Show 20 Lines onConcludeEntryEditMode = (entryInfo: EntryInfoWithHeight) => {
} }
}; };
keyboardShow = (event: KeyboardEvent) => { keyboardShow = (event: KeyboardEvent) => {
// flatListHeight() factors in the size of the tab bar, // flatListHeight() factors in the size of the tab bar,
// but it is hidden by the keyboard since it is at the bottom // but it is hidden by the keyboard since it is at the bottom
const { bottomInset, tabBarHeight } = this.props.dimensions; const { bottomInset, tabBarHeight } = this.props.dimensions;
const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5; const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5;
const keyboardHeight = Platform.select({ const keyboardHeight: number = Platform.select({
// Android doesn't include the bottomInset in this height measurement // Android doesn't include the bottomInset in this height measurement
android: event.endCoordinates.height, android: event.endCoordinates.height,
default: Math.max(event.endCoordinates.height - bottomInset, 0), default: Math.max(event.endCoordinates.height - bottomInset, 0),
}); });
const keyboardShownHeight = const keyboardShownHeight =
inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0); inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0);
this.keyboardShownHeight = keyboardShownHeight; this.keyboardShownHeight = keyboardShownHeight;
▲ Show 20 Lines • Show All 332 Lines • Show Last 20 Lines
View Options

services/tunnelbroker/src/websockets/mod.rs

Show First 20 Lines • Show All 766 Lines • ▼ Show 20 Lines onConcludeEntryEditMode = (entryInfo: EntryInfoWithHeight) => {
} }
}; };
keyboardShow = (event: KeyboardEvent) => { keyboardShow = (event: KeyboardEvent) => {
// flatListHeight() factors in the size of the tab bar, // flatListHeight() factors in the size of the tab bar,
// but it is hidden by the keyboard since it is at the bottom // but it is hidden by the keyboard since it is at the bottom
const { bottomInset, tabBarHeight } = this.props.dimensions; const { bottomInset, tabBarHeight } = this.props.dimensions;
const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5; const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5;
const keyboardHeight = Platform.select({ const keyboardHeight: number = Platform.select({
// Android doesn't include the bottomInset in this height measurement // Android doesn't include the bottomInset in this height measurement
android: event.endCoordinates.height, android: event.endCoordinates.height,
default: Math.max(event.endCoordinates.height - bottomInset, 0), default: Math.max(event.endCoordinates.height - bottomInset, 0),
}); });
const keyboardShownHeight = const keyboardShownHeight =
inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0); inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0);
this.keyboardShownHeight = keyboardShownHeight; this.keyboardShownHeight = keyboardShownHeight;
▲ Show 20 Lines • Show All 332 Lines • Show Last 20 Lines
View Options

services/tunnelbroker/src/websockets/session.rs

Show First 20 Lines • Show All 766 Lines • ▼ Show 20 Lines onConcludeEntryEditMode = (entryInfo: EntryInfoWithHeight) => {
} }
}; };
keyboardShow = (event: KeyboardEvent) => { keyboardShow = (event: KeyboardEvent) => {
// flatListHeight() factors in the size of the tab bar, // flatListHeight() factors in the size of the tab bar,
// but it is hidden by the keyboard since it is at the bottom // but it is hidden by the keyboard since it is at the bottom
const { bottomInset, tabBarHeight } = this.props.dimensions; const { bottomInset, tabBarHeight } = this.props.dimensions;
const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5; const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5;
const keyboardHeight = Platform.select({ const keyboardHeight: number = Platform.select({
// Android doesn't include the bottomInset in this height measurement // Android doesn't include the bottomInset in this height measurement
android: event.endCoordinates.height, android: event.endCoordinates.height,
default: Math.max(event.endCoordinates.height - bottomInset, 0), default: Math.max(event.endCoordinates.height - bottomInset, 0),
}); });
const keyboardShownHeight = const keyboardShownHeight =
inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0); inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0);
this.keyboardShownHeight = keyboardShownHeight; this.keyboardShownHeight = keyboardShownHeight;
▲ Show 20 Lines • Show All 332 Lines • Show Last 20 Lines