Paths

Table of Contentst

-
services/tunnelbroker/src/
-
tunnelbroker/
-
src/
-
main.rs
-
notifs/apns/
-
apns/
-
error.rs
-
mod.rs

[Tunnelbroker] implement creating APNs client
AbandonedPublicDraft
Actions

Authored by kamil on Jul 2 2024, 4:07 AM.

Details

Reviewers

bartek
marcin

Summary

Implementing APNs client which will handle sending notifs.

After some research I discovered that opening new connections for every request could be treated as DoS attack. However, reqwest can handle that, if we use the same Client and when making request it will use keep-alive connection pooling.

Depends on D12610

Test Plan

Test creating client with adding config args from CMD.

Diff Detail

Repository

rCOMM Comm

Branch

land-apns

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jul 2 2024, 4:07 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 2 2024, 4:07 AM

Copy of D12612 - published by a mistake

Harbormaster completed remote builds in B30045: Diff 41876.Jul 2 2024, 4:25 AM

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

main.rs

25 lines

notifs/

apns/

error.rs

1 line

mod.rs

24 lines

Diff 41876

View Options

services/tunnelbroker/src/main.rs

Show All 18 Lines	jsi::Array KeyserverStore::parseDBDataStore(
std::shared_ptr<std::vector<KeyserverInfo>> keyserversVectorPtr) const {		std::shared_ptr<std::vector<KeyserverInfo>> keyserversVectorPtr) const {
size_t numKeyservers = keyserversVectorPtr->size();		size_t numKeyservers = keyserversVectorPtr->size();
jsi::Array jsiKeyservers = jsi::Array(rt, numKeyservers);		jsi::Array jsiKeyservers = jsi::Array(rt, numKeyservers);
size_t writeIdx = 0;		size_t writeIdx = 0;
for (const KeyserverInfo &keyserver : *keyserversVectorPtr) {		for (const KeyserverInfo &keyserver : *keyserversVectorPtr) {
jsi::Object jsiKeyserver = jsi::Object(rt);		jsi::Object jsiKeyserver = jsi::Object(rt);
jsiKeyserver.setProperty(rt, "id", keyserver.id);		jsiKeyserver.setProperty(rt, "id", keyserver.id);
jsiKeyserver.setProperty(rt, "keyserverInfo", keyserver.keyserver_info);		jsiKeyserver.setProperty(rt, "keyserverInfo", keyserver.keyserver_info);
		jsiKeyserver.setProperty(
		rt, "syncedKeyserverInfo", keyserver.synced_keyserver_info);
jsiKeyservers.setValueAtIndex(rt, writeIdx++, jsiKeyserver);		jsiKeyservers.setValueAtIndex(rt, writeIdx++, jsiKeyserver);
}		}
return jsiKeyservers;		return jsiKeyservers;
}		}

std::vector<std::unique_ptr<KeyserverStoreOperationBase>>		std::vector<std::unique_ptr<KeyserverStoreOperationBase>>
KeyserverStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)		KeyserverStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)
const {		const {
Show All 20 Lines	for (size_t idx = 0; idx < operations.size(rt); idx++) {
} else if (opType == REMOVE_ALL_OPERATION) {		} else if (opType == REMOVE_ALL_OPERATION) {
keyserverStoreOps.push_back(		keyserverStoreOps.push_back(
std::make_unique<RemoveAllKeyserversOperation>());		std::make_unique<RemoveAllKeyserversOperation>());
} else if (opType == REPLACE_OPERATION) {		} else if (opType == REPLACE_OPERATION) {
jsi::Object payloadObj = op.getProperty(rt, "payload").asObject(rt);		jsi::Object payloadObj = op.getProperty(rt, "payload").asObject(rt);
std::string id = payloadObj.getProperty(rt, "id").asString(rt).utf8(rt);		std::string id = payloadObj.getProperty(rt, "id").asString(rt).utf8(rt);
std::string keyserver_info =		std::string keyserver_info =
payloadObj.getProperty(rt, "keyserverInfo").asString(rt).utf8(rt);		payloadObj.getProperty(rt, "keyserverInfo").asString(rt).utf8(rt);
		std::string synced_keyserver_info =
		payloadObj.getProperty(rt, "syncedKeyserverInfo")
		.asString(rt)
		.utf8(rt);

KeyserverInfo keyserver{id, keyserver_info};		KeyserverInfo keyserver{id, keyserver_info, synced_keyserver_info};

keyserverStoreOps.push_back(		keyserverStoreOps.push_back(
std::make_unique<ReplaceKeyserverOperation>(std::move(keyserver)));		std::make_unique<ReplaceKeyserverOperation>(std::move(keyserver)));
} else {		} else {
throw std::runtime_error("unsupported operation: " + opType);		throw std::runtime_error("unsupported operation: " + opType);
}		}
};		};
return keyserverStoreOps;		return keyserverStoreOps;
}		}

} // namespace comm		} // namespace comm

View Options

services/tunnelbroker/src/notifs/apns/error.rs

Show All 18 Lines	jsi::Array KeyserverStore::parseDBDataStore(
std::shared_ptr<std::vector<KeyserverInfo>> keyserversVectorPtr) const {		std::shared_ptr<std::vector<KeyserverInfo>> keyserversVectorPtr) const {
size_t numKeyservers = keyserversVectorPtr->size();		size_t numKeyservers = keyserversVectorPtr->size();
jsi::Array jsiKeyservers = jsi::Array(rt, numKeyservers);		jsi::Array jsiKeyservers = jsi::Array(rt, numKeyservers);
size_t writeIdx = 0;		size_t writeIdx = 0;
for (const KeyserverInfo &keyserver : *keyserversVectorPtr) {		for (const KeyserverInfo &keyserver : *keyserversVectorPtr) {
jsi::Object jsiKeyserver = jsi::Object(rt);		jsi::Object jsiKeyserver = jsi::Object(rt);
jsiKeyserver.setProperty(rt, "id", keyserver.id);		jsiKeyserver.setProperty(rt, "id", keyserver.id);
jsiKeyserver.setProperty(rt, "keyserverInfo", keyserver.keyserver_info);		jsiKeyserver.setProperty(rt, "keyserverInfo", keyserver.keyserver_info);
		jsiKeyserver.setProperty(
		rt, "syncedKeyserverInfo", keyserver.synced_keyserver_info);
jsiKeyservers.setValueAtIndex(rt, writeIdx++, jsiKeyserver);		jsiKeyservers.setValueAtIndex(rt, writeIdx++, jsiKeyserver);
}		}
return jsiKeyservers;		return jsiKeyservers;
}		}

std::vector<std::unique_ptr<KeyserverStoreOperationBase>>		std::vector<std::unique_ptr<KeyserverStoreOperationBase>>
KeyserverStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)		KeyserverStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)
const {		const {
Show All 20 Lines	for (size_t idx = 0; idx < operations.size(rt); idx++) {
} else if (opType == REMOVE_ALL_OPERATION) {		} else if (opType == REMOVE_ALL_OPERATION) {
keyserverStoreOps.push_back(		keyserverStoreOps.push_back(
std::make_unique<RemoveAllKeyserversOperation>());		std::make_unique<RemoveAllKeyserversOperation>());
} else if (opType == REPLACE_OPERATION) {		} else if (opType == REPLACE_OPERATION) {
jsi::Object payloadObj = op.getProperty(rt, "payload").asObject(rt);		jsi::Object payloadObj = op.getProperty(rt, "payload").asObject(rt);
std::string id = payloadObj.getProperty(rt, "id").asString(rt).utf8(rt);		std::string id = payloadObj.getProperty(rt, "id").asString(rt).utf8(rt);
std::string keyserver_info =		std::string keyserver_info =
payloadObj.getProperty(rt, "keyserverInfo").asString(rt).utf8(rt);		payloadObj.getProperty(rt, "keyserverInfo").asString(rt).utf8(rt);
		std::string synced_keyserver_info =
		payloadObj.getProperty(rt, "syncedKeyserverInfo")
		.asString(rt)
		.utf8(rt);

KeyserverInfo keyserver{id, keyserver_info};		KeyserverInfo keyserver{id, keyserver_info, synced_keyserver_info};

keyserverStoreOps.push_back(		keyserverStoreOps.push_back(
std::make_unique<ReplaceKeyserverOperation>(std::move(keyserver)));		std::make_unique<ReplaceKeyserverOperation>(std::move(keyserver)));
} else {		} else {
throw std::runtime_error("unsupported operation: " + opType);		throw std::runtime_error("unsupported operation: " + opType);
}		}
};		};
return keyserverStoreOps;		return keyserverStoreOps;
}		}

} // namespace comm		} // namespace comm

View Options

services/tunnelbroker/src/notifs/apns/mod.rs

Show All 18 Lines	jsi::Array KeyserverStore::parseDBDataStore(
std::shared_ptr<std::vector<KeyserverInfo>> keyserversVectorPtr) const {		std::shared_ptr<std::vector<KeyserverInfo>> keyserversVectorPtr) const {
size_t numKeyservers = keyserversVectorPtr->size();		size_t numKeyservers = keyserversVectorPtr->size();
jsi::Array jsiKeyservers = jsi::Array(rt, numKeyservers);		jsi::Array jsiKeyservers = jsi::Array(rt, numKeyservers);
size_t writeIdx = 0;		size_t writeIdx = 0;
for (const KeyserverInfo &keyserver : *keyserversVectorPtr) {		for (const KeyserverInfo &keyserver : *keyserversVectorPtr) {
jsi::Object jsiKeyserver = jsi::Object(rt);		jsi::Object jsiKeyserver = jsi::Object(rt);
jsiKeyserver.setProperty(rt, "id", keyserver.id);		jsiKeyserver.setProperty(rt, "id", keyserver.id);
jsiKeyserver.setProperty(rt, "keyserverInfo", keyserver.keyserver_info);		jsiKeyserver.setProperty(rt, "keyserverInfo", keyserver.keyserver_info);
		jsiKeyserver.setProperty(
		rt, "syncedKeyserverInfo", keyserver.synced_keyserver_info);
jsiKeyservers.setValueAtIndex(rt, writeIdx++, jsiKeyserver);		jsiKeyservers.setValueAtIndex(rt, writeIdx++, jsiKeyserver);
}		}
return jsiKeyservers;		return jsiKeyservers;
}		}

std::vector<std::unique_ptr<KeyserverStoreOperationBase>>		std::vector<std::unique_ptr<KeyserverStoreOperationBase>>
KeyserverStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)		KeyserverStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)
const {		const {
Show All 20 Lines	for (size_t idx = 0; idx < operations.size(rt); idx++) {
} else if (opType == REMOVE_ALL_OPERATION) {		} else if (opType == REMOVE_ALL_OPERATION) {
keyserverStoreOps.push_back(		keyserverStoreOps.push_back(
std::make_unique<RemoveAllKeyserversOperation>());		std::make_unique<RemoveAllKeyserversOperation>());
} else if (opType == REPLACE_OPERATION) {		} else if (opType == REPLACE_OPERATION) {
jsi::Object payloadObj = op.getProperty(rt, "payload").asObject(rt);		jsi::Object payloadObj = op.getProperty(rt, "payload").asObject(rt);
std::string id = payloadObj.getProperty(rt, "id").asString(rt).utf8(rt);		std::string id = payloadObj.getProperty(rt, "id").asString(rt).utf8(rt);
std::string keyserver_info =		std::string keyserver_info =
payloadObj.getProperty(rt, "keyserverInfo").asString(rt).utf8(rt);		payloadObj.getProperty(rt, "keyserverInfo").asString(rt).utf8(rt);
		std::string synced_keyserver_info =
		payloadObj.getProperty(rt, "syncedKeyserverInfo")
		.asString(rt)
		.utf8(rt);

KeyserverInfo keyserver{id, keyserver_info};		KeyserverInfo keyserver{id, keyserver_info, synced_keyserver_info};

keyserverStoreOps.push_back(		keyserverStoreOps.push_back(
std::make_unique<ReplaceKeyserverOperation>(std::move(keyserver)));		std::make_unique<ReplaceKeyserverOperation>(std::move(keyserver)));
} else {		} else {
throw std::runtime_error("unsupported operation: " + opType);		throw std::runtime_error("unsupported operation: " + opType);
}		}
};		};
return keyserverStoreOps;		return keyserverStoreOps;
}		}

} // namespace comm		} // namespace comm

[Tunnelbroker] implement creating APNs clientAbandonedPublicDraftActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41876

services/tunnelbroker/src/main.rs

services/tunnelbroker/src/notifs/apns/error.rs

services/tunnelbroker/src/notifs/apns/mod.rs

[Tunnelbroker] implement creating APNs client
AbandonedPublicDraft
Actions

Revision Contents
Changeset List