Page MenuHomePhabricator
Differential D12656

[lib] Make it possible to skip some thread/message properties
ClosedPublic
Actions

Authored by ashoat on Jul 3 2024, 7:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 14, 1:47 PM
Unknown Object (File)
Feb 27 2025, 7:15 AM
Unknown Object (File)
Feb 26 2025, 11:50 AM
Unknown Object (File)
Feb 24 2025, 8:02 PM
Unknown Object (File)
Feb 21 2025, 12:56 AM
Unknown Object (File)
Feb 21 2025, 12:56 AM
Unknown Object (File)
Feb 21 2025, 12:56 AM
Unknown Object (File)
Feb 21 2025, 12:56 AM
View All 76 Files
Subscribers
None

Details

Reviewers
tomek
marcin
inka
Commits
rCOMM4f9c9876a478: [lib] Make it possible to skip some thread/message properties
Summary

These are optional anyways, so we might as well allow them to not be included.

Depends on D12655

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Jul 3 2024, 7:51 PM
ashoat added a child revision: D12657: [lib] Permissions for thick threads.Jul 3 2024, 7:56 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 3 2024, 8:06 PM
Harbormaster failed remote builds in B30106: Diff 41977!
ashoat updated this revision to Diff 41983.Jul 3 2024, 8:12 PM

Rebase

Harbormaster completed remote builds in B30112: Diff 41983.Jul 3 2024, 8:34 PM
ashoat requested review of this revision.Jul 3 2024, 8:34 PM
ashoat added a child revision: D12660: [keyserver] Update ServerThreadInfo to only cover ThinThreadType.Jul 3 2024, 8:43 PM
ashoat removed a child revision: D12657: [lib] Permissions for thick threads.Jul 3 2024, 8:44 PM
inka accepted this revision.Jul 4 2024, 6:09 AM
This revision is now accepted and ready to land.Jul 4 2024, 6:09 AM
Closed by commit rCOMM4f9c9876a478: [lib] Make it possible to skip some thread/message properties (authored by ashoat). · Explain WhyJul 4 2024, 11:15 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM4f9c9876a478: [lib] Make it possible to skip some thread/message properties.

Revision Contents
Changeset List

PathSize
lib/
types/
messages/
4 lines
8 lines
16 lines

Diff 41977

View Options

lib/types/messages/create-sidebar.js

Show All 40 Lines
import { TextInput } from './modal-components.react.js'; import { TextInput } from './modal-components.react.js';
import { setNativeCredentials } from './native-credentials.js'; import { setNativeCredentials } from './native-credentials.js';
import { PanelButton, Panel } from './panel-components.react.js'; import { PanelButton, Panel } from './panel-components.react.js';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { nativeLogInExtraInfoSelector } from '../selectors/account-selectors.js'; import { nativeLogInExtraInfoSelector } from '../selectors/account-selectors.js';
import type { KeyPressEvent } from '../types/react-native.js'; import type { KeyPressEvent } from '../types/react-native.js';
import { AppOutOfDateAlertDetails } from '../utils/alert-messages.js'; import {
AppOutOfDateAlertDetails,
UsernameReservedAlertDetails,
UsernameTakenAlertDetails,
} from '../utils/alert-messages.js';
import Alert from '../utils/alert.js'; import Alert from '../utils/alert.js';
import { nativeNotificationsSessionCreator } from '../utils/crypto-utils.js'; import { nativeNotificationsSessionCreator } from '../utils/crypto-utils.js';
import { type StateContainer } from '../utils/state-container.js'; import { type StateContainer } from '../utils/state-container.js';
type WritableRegisterState = { type WritableRegisterState = {
usernameInputText: string, usernameInputText: string,
passwordInputText: string, passwordInputText: string,
confirmPasswordInputText: string, confirmPasswordInputText: string,
▲ Show 20 Lines • Show All 302 Lines • ▼ Show 20 Lines try {
await setNativeCredentials({ await setNativeCredentials({
username: result.currentUserInfo.username, username: result.currentUserInfo.username,
password: this.props.registerState.state.passwordInputText, password: this.props.registerState.state.passwordInputText,
}); });
return result; return result;
} catch (e) { } catch (e) {
if (e.message === 'username_reserved') { if (e.message === 'username_reserved') {
Alert.alert( Alert.alert(
'Username reserved', UsernameReservedAlertDetails.title,
'This username is currently reserved. Please contact support@' + UsernameReservedAlertDetails.message,
'comm.app if you would like to claim this account.',
[{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }], [{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }],
{ cancelable: false }, { cancelable: false },
); );
} else if (e.message === 'username_taken') { } else if (e.message === 'username_taken') {
Alert.alert( Alert.alert(
'Username taken', UsernameTakenAlertDetails.title,
'An account with that username already exists', UsernameTakenAlertDetails.message,
[{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }], [{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }],
{ cancelable: false }, { cancelable: false },
); );
} else if (e.message === 'client_version_unsupported') { } else if (e.message === 'client_version_unsupported') {
Alert.alert( Alert.alert(
AppOutOfDateAlertDetails.title, AppOutOfDateAlertDetails.title,
AppOutOfDateAlertDetails.message, AppOutOfDateAlertDetails.message,
[{ text: 'OK', onPress: this.onAppOutOfDateAlertAcknowledged }], [{ text: 'OK', onPress: this.onAppOutOfDateAlertAcknowledged }],
▲ Show 20 Lines • Show All 120 Lines • Show Last 20 Lines
View Options

lib/types/messages/create-thread.js

Show All 40 Lines
import { TextInput } from './modal-components.react.js'; import { TextInput } from './modal-components.react.js';
import { setNativeCredentials } from './native-credentials.js'; import { setNativeCredentials } from './native-credentials.js';
import { PanelButton, Panel } from './panel-components.react.js'; import { PanelButton, Panel } from './panel-components.react.js';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { nativeLogInExtraInfoSelector } from '../selectors/account-selectors.js'; import { nativeLogInExtraInfoSelector } from '../selectors/account-selectors.js';
import type { KeyPressEvent } from '../types/react-native.js'; import type { KeyPressEvent } from '../types/react-native.js';
import { AppOutOfDateAlertDetails } from '../utils/alert-messages.js'; import {
AppOutOfDateAlertDetails,
UsernameReservedAlertDetails,
UsernameTakenAlertDetails,
} from '../utils/alert-messages.js';
import Alert from '../utils/alert.js'; import Alert from '../utils/alert.js';
import { nativeNotificationsSessionCreator } from '../utils/crypto-utils.js'; import { nativeNotificationsSessionCreator } from '../utils/crypto-utils.js';
import { type StateContainer } from '../utils/state-container.js'; import { type StateContainer } from '../utils/state-container.js';
type WritableRegisterState = { type WritableRegisterState = {
usernameInputText: string, usernameInputText: string,
passwordInputText: string, passwordInputText: string,
confirmPasswordInputText: string, confirmPasswordInputText: string,
▲ Show 20 Lines • Show All 302 Lines • ▼ Show 20 Lines try {
await setNativeCredentials({ await setNativeCredentials({
username: result.currentUserInfo.username, username: result.currentUserInfo.username,
password: this.props.registerState.state.passwordInputText, password: this.props.registerState.state.passwordInputText,
}); });
return result; return result;
} catch (e) { } catch (e) {
if (e.message === 'username_reserved') { if (e.message === 'username_reserved') {
Alert.alert( Alert.alert(
'Username reserved', UsernameReservedAlertDetails.title,
'This username is currently reserved. Please contact support@' + UsernameReservedAlertDetails.message,
'comm.app if you would like to claim this account.',
[{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }], [{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }],
{ cancelable: false }, { cancelable: false },
); );
} else if (e.message === 'username_taken') { } else if (e.message === 'username_taken') {
Alert.alert( Alert.alert(
'Username taken', UsernameTakenAlertDetails.title,
'An account with that username already exists', UsernameTakenAlertDetails.message,
[{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }], [{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }],
{ cancelable: false }, { cancelable: false },
); );
} else if (e.message === 'client_version_unsupported') { } else if (e.message === 'client_version_unsupported') {
Alert.alert( Alert.alert(
AppOutOfDateAlertDetails.title, AppOutOfDateAlertDetails.title,
AppOutOfDateAlertDetails.message, AppOutOfDateAlertDetails.message,
[{ text: 'OK', onPress: this.onAppOutOfDateAlertAcknowledged }], [{ text: 'OK', onPress: this.onAppOutOfDateAlertAcknowledged }],
▲ Show 20 Lines • Show All 120 Lines • Show Last 20 Lines
View Options

lib/types/thread-types.js

Show All 40 Lines
import { TextInput } from './modal-components.react.js'; import { TextInput } from './modal-components.react.js';
import { setNativeCredentials } from './native-credentials.js'; import { setNativeCredentials } from './native-credentials.js';
import { PanelButton, Panel } from './panel-components.react.js'; import { PanelButton, Panel } from './panel-components.react.js';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { nativeLogInExtraInfoSelector } from '../selectors/account-selectors.js'; import { nativeLogInExtraInfoSelector } from '../selectors/account-selectors.js';
import type { KeyPressEvent } from '../types/react-native.js'; import type { KeyPressEvent } from '../types/react-native.js';
import { AppOutOfDateAlertDetails } from '../utils/alert-messages.js'; import {
AppOutOfDateAlertDetails,
UsernameReservedAlertDetails,
UsernameTakenAlertDetails,
} from '../utils/alert-messages.js';
import Alert from '../utils/alert.js'; import Alert from '../utils/alert.js';
import { nativeNotificationsSessionCreator } from '../utils/crypto-utils.js'; import { nativeNotificationsSessionCreator } from '../utils/crypto-utils.js';
import { type StateContainer } from '../utils/state-container.js'; import { type StateContainer } from '../utils/state-container.js';
type WritableRegisterState = { type WritableRegisterState = {
usernameInputText: string, usernameInputText: string,
passwordInputText: string, passwordInputText: string,
confirmPasswordInputText: string, confirmPasswordInputText: string,
▲ Show 20 Lines • Show All 302 Lines • ▼ Show 20 Lines try {
await setNativeCredentials({ await setNativeCredentials({
username: result.currentUserInfo.username, username: result.currentUserInfo.username,
password: this.props.registerState.state.passwordInputText, password: this.props.registerState.state.passwordInputText,
}); });
return result; return result;
} catch (e) { } catch (e) {
if (e.message === 'username_reserved') { if (e.message === 'username_reserved') {
Alert.alert( Alert.alert(
'Username reserved', UsernameReservedAlertDetails.title,
'This username is currently reserved. Please contact support@' + UsernameReservedAlertDetails.message,
'comm.app if you would like to claim this account.',
[{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }], [{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }],
{ cancelable: false }, { cancelable: false },
); );
} else if (e.message === 'username_taken') { } else if (e.message === 'username_taken') {
Alert.alert( Alert.alert(
'Username taken', UsernameTakenAlertDetails.title,
'An account with that username already exists', UsernameTakenAlertDetails.message,
[{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }], [{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }],
{ cancelable: false }, { cancelable: false },
); );
} else if (e.message === 'client_version_unsupported') { } else if (e.message === 'client_version_unsupported') {
Alert.alert( Alert.alert(
AppOutOfDateAlertDetails.title, AppOutOfDateAlertDetails.title,
AppOutOfDateAlertDetails.message, AppOutOfDateAlertDetails.message,
[{ text: 'OK', onPress: this.onAppOutOfDateAlertAcknowledged }], [{ text: 'OK', onPress: this.onAppOutOfDateAlertAcknowledged }],
▲ Show 20 Lines • Show All 120 Lines • Show Last 20 Lines