Page MenuHomePhabricator

[terraform] add authoritative keyserver id as a user-specified variable
ClosedPublic

Authored by will on Jul 9 2024, 7:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 10:55 PM
Unknown Object (File)
Fri, Nov 22, 7:20 PM
Unknown Object (File)
Tue, Nov 12, 9:26 AM
Unknown Object (File)
Tue, Nov 12, 8:45 AM
Unknown Object (File)
Tue, Nov 12, 3:26 AM
Unknown Object (File)
Fri, Nov 8, 11:05 PM
Unknown Object (File)
Fri, Nov 8, 1:00 PM
Unknown Object (File)
Fri, Nov 8, 12:26 PM
Subscribers

Details

Summary

Introduce specifying the authoritative keyserver id as a terraform variable which translates to a keyserver environmental variable

Depends on D12709

Test Plan

In our prior testing, wasn't able to connect a debug native client without specifying the authoritative id to the keyserver.
With this configuration, was able to connect properly. Previously set this manually

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will requested review of this revision.Jul 9 2024, 7:45 PM
services/terraform/self-host/variables.tf
40–41 ↗(On Diff #42190)

Should we rename this something like authoritative_keyserver_user_id for clarity? At the least, it would be helpful to clarify in the description that it's a user ID

will added inline comments.
services/terraform/self-host/variables.tf
40–41 ↗(On Diff #42190)

Yeah. I think that'd be helpful to the user. I'll also update the description as well

Including in next rebase

This revision is now accepted and ready to land.Jul 17 2024, 12:45 AM

make authoritative id variable a config json object