Paths

Table of Contentst

[terraform] Make number of secondary nodes configured by the user
ClosedPublic
Actions

Authored by will on Jul 11 2024, 10:07 AM.

Details

Reviewers

varun
bartek

Commits

rCOMMfbd439f617c5: [terraform] Make number of secondary nodes configured by the user

Summary

This allows the user to configure the amount of secondary nodes they want to launch.

I think that we'll want to consider some more advanced auto-scaling logic in the future to automatically launch secondary nodes, but configuring this to be
user-defined for now

Depends on D12725

Test Plan

terraform apply. Setting variable to 2 caused 2 secondary nodes tasks to deploy

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Jul 11 2024, 10:07 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 11 2024, 10:07 AM

will added a child revision: D12730: [terraform] Ensure that the primary service is running before deploying secondary service.Jul 11 2024, 10:12 AM

Harbormaster completed remote builds in B30290: Diff 42237.Jul 11 2024, 10:24 AM

will requested review of this revision.Jul 11 2024, 10:24 AM

bartek accepted this revision.Jul 17 2024, 12:52 AM

bartek added inline comments.

services/terraform/self-host/variables.tf
69–72 ↗	(On Diff #42237)	Should we specify `default = 1` (previous `desired_count` value)?

This revision is now accepted and ready to land.Jul 17 2024, 12:52 AM

feedback

Harbormaster completed remote builds in B30453: Diff 42434.Jul 17 2024, 5:33 PM

Closed by commit rCOMMfbd439f617c5: [terraform] Make number of secondary nodes configured by the user (authored by will). · Explain WhyJul 17 2024, 7:03 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMMfbd439f617c5: [terraform] Make number of secondary nodes configured by the user.

Revision Contents
Changeset List

Path

Size

services/

terraform/

self-host/

keyserver_secondary.tf

2 lines

variables.tf

6 lines

Diff 42451

View Options

services/terraform/self-host/keyserver_secondary.tf