Page MenuHomePhabricator
Differential D12819

[identity] redact_sensitive_data config
ClosedPublic
Actions

Authored by varun on Jul 19 2024, 11:39 PM.
Tags
None
Referenced Files
F3000342: D12819.diff
Fri, Oct 18, 1:41 AM
Unknown Object (File)
Wed, Sep 25, 7:05 PM
Unknown Object (File)
Wed, Sep 25, 7:05 PM
Unknown Object (File)
Wed, Sep 25, 7:05 PM
Unknown Object (File)
Wed, Sep 25, 7:03 PM
Unknown Object (File)
Wed, Sep 25, 7:01 PM
Unknown Object (File)
Sep 9 2024, 12:45 AM
Unknown Object (File)
Aug 29 2024, 2:14 PM
View All 40 Files
Subscribers
tomek

Details

Reviewers
will
bartek
ashoat
Commits
rCOMMa7cfa610e0f3: [identity] redact_sensitive_data config
Summary

we'll use this config in the next diff to conditionally hide sensitive data from our logs

Test Plan

tested in next diff by setting the config and then calling the ping RPC, which i modified to log some sensitive data. confirmed that with the config set to true, the data is redacted in the logs

will also verify that sensitive data is now redacted on prod after next prod deployment

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Jul 19 2024, 11:39 PM
Herald added a subscriber: tomek. · View Herald TranscriptJul 19 2024, 11:39 PM
varun added a child revision: D12820: [identity] use redact_sensitive_data config to redact sensitive data in logs.Jul 19 2024, 11:41 PM
varun mentioned this in D12818: [identity] remove user ID from "no device list" log.Jul 19 2024, 11:41 PM
Harbormaster completed remote builds in B30537: Diff 42582.Jul 19 2024, 11:55 PM
varun requested review of this revision.Jul 19 2024, 11:55 PM
varun updated this revision to Diff 42586.Jul 20 2024, 12:01 AM

env var should be string

Harbormaster failed remote builds in B30541: Diff 42586!Jul 20 2024, 12:23 AM
Harbormaster completed remote builds in B30541: Diff 42586.Jul 20 2024, 12:38 AM
ashoat resigned from this revision.Jul 21 2024, 10:15 PM

Looks good but would prefer somebody with Terraform / Rust experience reviewed

bartek accepted this revision.Jul 22 2024, 1:09 AM
This revision is now accepted and ready to land.Jul 22 2024, 1:09 AM
Closed by commit rCOMMa7cfa610e0f3: [identity] redact_sensitive_data config (authored by varun). · Explain WhyJul 22 2024, 7:40 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMa7cfa610e0f3: [identity] redact_sensitive_data config.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
11 lines
1 line
terraform/
remote/
4 lines

Diff 42586

View Options

services/identity/src/config.rs

Loading...
View Options

services/identity/src/constants.rs

Loading...
View Options

services/terraform/remote/service_identity.tf

Loading...