Paths

Table of Contentst

Differential D12895

[tunnelbroker][lib] Add WebPush notif message type
ClosedPublic
Actions

Authored by bartek on Jul 26 2024, 6:25 AM.

Tags

None

Referenced Files

	F2999530: D12895.diff
	Thu, Oct 17, 11:19 PM

	Unknown Object (File)
	Wed, Sep 25, 5:16 PM

	Unknown Object (File)
	Wed, Sep 25, 5:15 PM

	Unknown Object (File)
	Wed, Sep 25, 5:13 PM

	Unknown Object (File)
	Sep 11 2024, 6:29 PM

	Unknown Object (File)
	Sep 10 2024, 12:55 AM

	Unknown Object (File)
	Sep 9 2024, 3:10 PM

	Unknown Object (File)
	Sep 9 2024, 11:59 AM

View All 49 Files

Subscribers

Details

Reviewers

kamil
marcin

Commits

rCOMM61bfe5dd37da: [tunnelbroker][lib] Add WebPush notif message type

Summary

Message send from client to send notif using WebPush service.

Depends on D12894

Test Plan

Tested together with the rest of the stack.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jul 26 2024, 6:25 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 26 2024, 6:26 AM

bartek added a child revision: D12896: [tunnelbroker] Implement sending WebPush notifs by clients.Jul 26 2024, 6:27 AM

bartek published this revision for review.Jul 26 2024, 6:40 AM

Harbormaster failed remote builds in B30710: Diff 42833!Jul 26 2024, 6:49 AM

bartek mentioned this in D12901: [shared][rust] Add proc-macro to deserialize tagged enum variants.Jul 28 2024, 7:12 AM

Add TagAwareDeserialize to the struct. This should fix CI

bartek added a parent revision: D12903: [util-macros] Improve TagAwareDeserialize to read serde attributes.Jul 28 2024, 7:22 AM

Harbormaster completed remote builds in B30724: Diff 42850.Jul 28 2024, 7:36 AM

kamil accepted this revision.Jul 29 2024, 2:12 AM

kamil added inline comments.

shared/tunnelbroker_messages/src/messages/notif.rs
29 ↗	(On Diff #42850)	Is it worth adding `TagAwareDeserialize` to all structs used here? I think there are other having the same structure and only tag is different

This revision is now accepted and ready to land.Jul 29 2024, 2:12 AM

bartek added inline comments.Jul 29 2024, 5:52 AM

shared/tunnelbroker_messages/src/messages/notif.rs
29 ↗	(On Diff #42850)	Yes it is, but I also want to unit test all of them, Created https://linear.app/comm/issue/ENG-8905/add-tagawaredeserialize-to-messages-and-test-serialization to track this

Closed by commit rCOMM61bfe5dd37da: [tunnelbroker][lib] Add WebPush notif message type (authored by bartek). · Explain WhyJul 29 2024, 5:56 AM

This revision was automatically updated to reflect the committed changes.

bartek mentioned this in rCOMM9463274996c6: [shared][rust] Add proc-macro to deserialize tagged enum variants.

bartek added a commit: rCOMM61bfe5dd37da: [tunnelbroker][lib] Add WebPush notif message type.

Revision Contents
Changeset List

Path

Size

lib/

types/

tunnelbroker/

12 lines

shared/

tunnelbroker_messages/

src/

messages/

1 line

11 lines

Diff 42833

lib/types/tunnelbroker/notif-types.js

Loading...

shared/tunnelbroker_messages/src/messages/mod.rs

Loading...

shared/tunnelbroker_messages/src/messages/notif.rs

Loading...