Page MenuHomePhabricator
Differential D12903

[util-macros] Improve TagAwareDeserialize to read serde attributes
ClosedPublic
Actions

Authored by bartek on Jul 28 2024, 7:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 5, 12:24 AM
Unknown Object (File)
Mon, Mar 3, 6:24 AM
Unknown Object (File)
Mon, Mar 3, 6:24 AM
Unknown Object (File)
Mon, Mar 3, 6:24 AM
Unknown Object (File)
Fri, Feb 28, 6:05 AM
Unknown Object (File)
Fri, Feb 28, 5:02 AM
Unknown Object (File)
Jan 25 2025, 6:01 PM
Unknown Object (File)
Jan 22 2025, 3:39 PM
View All 100 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
will
kamil
Commits
rCOMMe33868cba63d: [util-macros] Improve TagAwareDeserialize to read serde attributes
Summary

Some small improvements to the TagAwareDeserialize macro:

  • Verify if #[serde(remote = "Self", tag = "...")] is present
  • Allow any serde tag, not necessarily "type"

Depends on D12902

Test Plan

cargo test - Macro still works

Removing e.g. tag results in IDE (rust-analyzer) error:

Screenshot 2024-07-28 at 16.39.21.png (348×1 px, 115 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Jul 28 2024, 7:18 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 28 2024, 7:18 AM
bartek added a child revision: D12895: [tunnelbroker][lib] Add WebPush notif message type.Jul 28 2024, 7:22 AM
bartek edited the test plan for this revision. (Show Details)Jul 28 2024, 7:28 AM
bartek attached a referenced file: F2344448: Screenshot 2024-07-28 at 16.27.00.png. (Show Details)
Harbormaster completed remote builds in B30723: Diff 42849.Jul 28 2024, 7:33 AM
bartek edited the test plan for this revision. (Show Details)Jul 28 2024, 7:39 AM
bartek attached a referenced file: F2344478: Screenshot 2024-07-28 at 16.39.21.png. (Show Details)
bartek updated this revision to Diff 42851.Jul 28 2024, 7:49 AM

Improve error handling

Harbormaster completed remote builds in B30725: Diff 42851.Jul 28 2024, 8:10 AM
bartek published this revision for review.Jul 28 2024, 8:11 AM
kamil accepted this revision.Jul 29 2024, 2:07 AM
This revision is now accepted and ready to land.Jul 29 2024, 2:07 AM
Closed by commit rCOMMe33868cba63d: [util-macros] Improve TagAwareDeserialize to read serde attributes (authored by bartek). · Explain WhyJul 29 2024, 5:56 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMe33868cba63d: [util-macros] Improve TagAwareDeserialize to read serde attributes.

Revision Contents
Changeset List

PathSize
shared/
util_macros/
src/
6 lines
58 lines

Diff 42887

View Options

shared/util_macros/src/lib.rs

Loading...
View Options

shared/util_macros/src/tag_aware_deserialize.rs

Loading...