Page MenuHomePhabricator
Differential D12901

[shared][rust] Add proc-macro to deserialize tagged enum variants
ClosedPublic
Actions

Authored by bartek on Jul 28 2024, 7:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 8, 4:28 PM
Unknown Object (File)
Tue, Apr 8, 4:12 PM
Unknown Object (File)
Tue, Apr 8, 11:19 AM
Unknown Object (File)
Mon, Apr 7, 5:24 AM
Unknown Object (File)
Sun, Mar 30, 9:16 PM
Unknown Object (File)
Sun, Mar 23, 2:00 PM
Unknown Object (File)
Mar 12 2025, 12:39 AM
Unknown Object (File)
Mar 11 2025, 10:44 AM
View All 76 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
will
kamil
Commits
rCOMM9463274996c6: [shared][rust] Add proc-macro to deserialize tagged enum variants
Summary

Detailed description of why we need this: ENG-8901.

Unfortunately, proc-macros need to be defined in a separate crate (see why), so I created a util-macros crate in our Cargo workspace.

Test Plan
  • Added rustdoc usage example
  • Rust unit tests added in the next diff
  • Used and tested in in D12895
  • Rust playground - see Linear description

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
shared/
util_macros/
15 lines
src/
62 lines
40 lines

Diff 42885

View Options

Cargo.lock

Show All 13 Linesimport {
type MessageTruncationStatuses, type MessageTruncationStatuses,
type GenericMessagesResult, type GenericMessagesResult,
} from './message-types.js'; } from './message-types.js';
import type { PreRequestUserState } from './session-types.js'; import type { PreRequestUserState } from './session-types.js';
import { import {
type RawThreadInfos, type RawThreadInfos,
type MinimallyEncodedRawThreadInfos, type MinimallyEncodedRawThreadInfos,
} from './thread-types.js'; } from './thread-types.js';
import { import type {
type UserInfo, CurrentUserInfo,
type LoggedOutUserInfo, UserInfo,
type LoggedInUserInfo, LoggedOutUserInfo,
} from './user-types.js'; LoggedInUserInfo,
} from './user-types';
import type { PolicyType } from '../facts/policies.js'; import type { PolicyType } from '../facts/policies.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { tShape } from '../utils/validation-utils.js'; import { tShape } from '../utils/validation-utils.js';
export type ResetPasswordRequest = { export type ResetPasswordRequest = {
+usernameOrEmail: string, +usernameOrEmail: string,
}; };
▲ Show 20 Lines • Show All 141 Lines • ▼ Show 20 Linesexport type KeyserverAuthResult = {
+threadInfos: RawThreadInfos, +threadInfos: RawThreadInfos,
+currentUserInfo?: ?LoggedInUserInfo, +currentUserInfo?: ?LoggedInUserInfo,
+messagesResult: GenericMessagesResult, +messagesResult: GenericMessagesResult,
+userInfos: $ReadOnlyArray<UserInfo>, +userInfos: $ReadOnlyArray<UserInfo>,
+calendarResult: CalendarResult, +calendarResult: CalendarResult,
+updatesCurrentAsOf: { +[keyserverID: string]: number }, +updatesCurrentAsOf: { +[keyserverID: string]: number },
+logInActionSource: LogInActionSource, +logInActionSource: LogInActionSource,
+notAcknowledgedPolicies?: ?$ReadOnlyArray<PolicyType>, +notAcknowledgedPolicies?: ?$ReadOnlyArray<PolicyType>,
+preRequestUserInfo: ?CurrentUserInfo,
}; };
type KeyserverRequestData = { type KeyserverRequestData = {
+initialContentEncryptedMessage: string, +initialContentEncryptedMessage: string,
+initialNotificationsEncryptedMessage: string, +initialNotificationsEncryptedMessage: string,
}; };
export type KeyserverAuthInfo = { export type KeyserverAuthInfo = {
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

shared/util_macros/Cargo.toml

Show All 13 Linesimport {
type MessageTruncationStatuses, type MessageTruncationStatuses,
type GenericMessagesResult, type GenericMessagesResult,
} from './message-types.js'; } from './message-types.js';
import type { PreRequestUserState } from './session-types.js'; import type { PreRequestUserState } from './session-types.js';
import { import {
type RawThreadInfos, type RawThreadInfos,
type MinimallyEncodedRawThreadInfos, type MinimallyEncodedRawThreadInfos,
} from './thread-types.js'; } from './thread-types.js';
import { import type {
type UserInfo, CurrentUserInfo,
type LoggedOutUserInfo, UserInfo,
type LoggedInUserInfo, LoggedOutUserInfo,
} from './user-types.js'; LoggedInUserInfo,
} from './user-types';
import type { PolicyType } from '../facts/policies.js'; import type { PolicyType } from '../facts/policies.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { tShape } from '../utils/validation-utils.js'; import { tShape } from '../utils/validation-utils.js';
export type ResetPasswordRequest = { export type ResetPasswordRequest = {
+usernameOrEmail: string, +usernameOrEmail: string,
}; };
▲ Show 20 Lines • Show All 141 Lines • ▼ Show 20 Linesexport type KeyserverAuthResult = {
+threadInfos: RawThreadInfos, +threadInfos: RawThreadInfos,
+currentUserInfo?: ?LoggedInUserInfo, +currentUserInfo?: ?LoggedInUserInfo,
+messagesResult: GenericMessagesResult, +messagesResult: GenericMessagesResult,
+userInfos: $ReadOnlyArray<UserInfo>, +userInfos: $ReadOnlyArray<UserInfo>,
+calendarResult: CalendarResult, +calendarResult: CalendarResult,
+updatesCurrentAsOf: { +[keyserverID: string]: number }, +updatesCurrentAsOf: { +[keyserverID: string]: number },
+logInActionSource: LogInActionSource, +logInActionSource: LogInActionSource,
+notAcknowledgedPolicies?: ?$ReadOnlyArray<PolicyType>, +notAcknowledgedPolicies?: ?$ReadOnlyArray<PolicyType>,
+preRequestUserInfo: ?CurrentUserInfo,
}; };
type KeyserverRequestData = { type KeyserverRequestData = {
+initialContentEncryptedMessage: string, +initialContentEncryptedMessage: string,
+initialNotificationsEncryptedMessage: string, +initialNotificationsEncryptedMessage: string,
}; };
export type KeyserverAuthInfo = { export type KeyserverAuthInfo = {
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

shared/util_macros/src/lib.rs

Show All 13 Linesimport {
type MessageTruncationStatuses, type MessageTruncationStatuses,
type GenericMessagesResult, type GenericMessagesResult,
} from './message-types.js'; } from './message-types.js';
import type { PreRequestUserState } from './session-types.js'; import type { PreRequestUserState } from './session-types.js';
import { import {
type RawThreadInfos, type RawThreadInfos,
type MinimallyEncodedRawThreadInfos, type MinimallyEncodedRawThreadInfos,
} from './thread-types.js'; } from './thread-types.js';
import { import type {
type UserInfo, CurrentUserInfo,
type LoggedOutUserInfo, UserInfo,
type LoggedInUserInfo, LoggedOutUserInfo,
} from './user-types.js'; LoggedInUserInfo,
} from './user-types';
import type { PolicyType } from '../facts/policies.js'; import type { PolicyType } from '../facts/policies.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { tShape } from '../utils/validation-utils.js'; import { tShape } from '../utils/validation-utils.js';
export type ResetPasswordRequest = { export type ResetPasswordRequest = {
+usernameOrEmail: string, +usernameOrEmail: string,
}; };
▲ Show 20 Lines • Show All 141 Lines • ▼ Show 20 Linesexport type KeyserverAuthResult = {
+threadInfos: RawThreadInfos, +threadInfos: RawThreadInfos,
+currentUserInfo?: ?LoggedInUserInfo, +currentUserInfo?: ?LoggedInUserInfo,
+messagesResult: GenericMessagesResult, +messagesResult: GenericMessagesResult,
+userInfos: $ReadOnlyArray<UserInfo>, +userInfos: $ReadOnlyArray<UserInfo>,
+calendarResult: CalendarResult, +calendarResult: CalendarResult,
+updatesCurrentAsOf: { +[keyserverID: string]: number }, +updatesCurrentAsOf: { +[keyserverID: string]: number },
+logInActionSource: LogInActionSource, +logInActionSource: LogInActionSource,
+notAcknowledgedPolicies?: ?$ReadOnlyArray<PolicyType>, +notAcknowledgedPolicies?: ?$ReadOnlyArray<PolicyType>,
+preRequestUserInfo: ?CurrentUserInfo,
}; };
type KeyserverRequestData = { type KeyserverRequestData = {
+initialContentEncryptedMessage: string, +initialContentEncryptedMessage: string,
+initialNotificationsEncryptedMessage: string, +initialNotificationsEncryptedMessage: string,
}; };
export type KeyserverAuthInfo = { export type KeyserverAuthInfo = {
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

shared/util_macros/src/tag_aware_deserialize.rs

Show All 13 Linesimport {
type MessageTruncationStatuses, type MessageTruncationStatuses,
type GenericMessagesResult, type GenericMessagesResult,
} from './message-types.js'; } from './message-types.js';
import type { PreRequestUserState } from './session-types.js'; import type { PreRequestUserState } from './session-types.js';
import { import {
type RawThreadInfos, type RawThreadInfos,
type MinimallyEncodedRawThreadInfos, type MinimallyEncodedRawThreadInfos,
} from './thread-types.js'; } from './thread-types.js';
import { import type {
type UserInfo, CurrentUserInfo,
type LoggedOutUserInfo, UserInfo,
type LoggedInUserInfo, LoggedOutUserInfo,
} from './user-types.js'; LoggedInUserInfo,
} from './user-types';
import type { PolicyType } from '../facts/policies.js'; import type { PolicyType } from '../facts/policies.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { tShape } from '../utils/validation-utils.js'; import { tShape } from '../utils/validation-utils.js';
export type ResetPasswordRequest = { export type ResetPasswordRequest = {
+usernameOrEmail: string, +usernameOrEmail: string,
}; };
▲ Show 20 Lines • Show All 141 Lines • ▼ Show 20 Linesexport type KeyserverAuthResult = {
+threadInfos: RawThreadInfos, +threadInfos: RawThreadInfos,
+currentUserInfo?: ?LoggedInUserInfo, +currentUserInfo?: ?LoggedInUserInfo,
+messagesResult: GenericMessagesResult, +messagesResult: GenericMessagesResult,
+userInfos: $ReadOnlyArray<UserInfo>, +userInfos: $ReadOnlyArray<UserInfo>,
+calendarResult: CalendarResult, +calendarResult: CalendarResult,
+updatesCurrentAsOf: { +[keyserverID: string]: number }, +updatesCurrentAsOf: { +[keyserverID: string]: number },
+logInActionSource: LogInActionSource, +logInActionSource: LogInActionSource,
+notAcknowledgedPolicies?: ?$ReadOnlyArray<PolicyType>, +notAcknowledgedPolicies?: ?$ReadOnlyArray<PolicyType>,
+preRequestUserInfo: ?CurrentUserInfo,
}; };
type KeyserverRequestData = { type KeyserverRequestData = {
+initialContentEncryptedMessage: string, +initialContentEncryptedMessage: string,
+initialNotificationsEncryptedMessage: string, +initialNotificationsEncryptedMessage: string,
}; };
export type KeyserverAuthInfo = { export type KeyserverAuthInfo = {
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines