Paths

Table of Contentst

-
shared/util_macros/tests/
-
util_macros/
-
tests/
-
tag_aware_deserialize.rs

Differential D12902

[util-macros] Add tests for serde and TagAwareDeserialize behavior
ClosedPublic
Actions

Authored by bartek on Jul 28 2024, 7:15 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Mar 15, 5:36 PM

	Unknown Object (File)
	Thu, Mar 6, 6:33 AM

	Unknown Object (File)
	Tue, Mar 4, 8:36 PM

	Unknown Object (File)
	Mon, Mar 3, 12:59 PM

	Unknown Object (File)
	Mon, Mar 3, 6:24 AM

	Unknown Object (File)
	Mon, Mar 3, 6:24 AM

	Unknown Object (File)
	Fri, Feb 28, 6:05 AM

	Unknown Object (File)
	Fri, Feb 28, 5:02 AM

View All 77 Files

Subscribers

Details

Reviewers

varun
will
kamil

Commits

rCOMMa1ec2400de91: [util-macros] Add tests for serde and TagAwareDeserialize behavior

Summary

Added tests to demonstrate both serde issue described in ENG-8901 and the macro introduced in D12901

Depends on D12901

Test Plan

cargo test

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jul 28 2024, 7:15 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 28 2024, 7:15 AM

bartek added a child revision: D12903: [util-macros] Improve TagAwareDeserialize to read serde attributes.Jul 28 2024, 7:18 AM

Harbormaster completed remote builds in B30722: Diff 42848.Jul 28 2024, 7:31 AM

bartek published this revision for review.Jul 28 2024, 8:10 AM

kamil accepted this revision.Jul 29 2024, 2:01 AM

This revision is now accepted and ready to land.Jul 29 2024, 2:01 AM

Closed by commit rCOMMa1ec2400de91: [util-macros] Add tests for serde and TagAwareDeserialize behavior (authored by bartek). · Explain WhyJul 29 2024, 5:56 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMa1ec2400de91: [util-macros] Add tests for serde and TagAwareDeserialize behavior.

Revision Contents
Changeset List

Path

Size

shared/

util_macros/

tests/

tag_aware_deserialize.rs

138 lines

Diff 42886

shared/util_macros/tests/tag_aware_deserialize.rs

				use tracing::error;

	pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>;			pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>;

	#[derive(			#[derive(
	Debug, derive_more::Display, derive_more::From, derive_more::Error,			Debug, derive_more::Display, derive_more::From, derive_more::Error,
	)]			)]
	pub enum WebsocketError {			pub enum WebsocketError {
	InvalidMessage,			InvalidMessage,
				InvalidSearchQuery,
	UnauthorizedDevice,			UnauthorizedDevice,
	SendError,			SendError,
	SearchError,			SearchError,
	AuthError,			AuthError,
	SerializationError,			SerializationError,
	}			}

				impl From<serde_json::Error> for WebsocketError {
				fn from(err: serde_json::Error) -> Self {
				tracing::error!("Error serializing: {}", err);
				WebsocketError::SerializationError
				}
				}

				impl From<reqwest::Error> for WebsocketError {
				fn from(err: reqwest::Error) -> Self {
				tracing::error!("Error with search request: {}", err);
				WebsocketError::SearchError
				}
				}