Page MenuHomePhabricator
Differential D12897

[lib] Implement sending WebPush notifs using Tunnelbroker
ClosedPublic
Actions

Authored by bartek on Jul 26 2024, 6:30 AM.
Tags
None
Referenced Files
F5118726: D12897.id42853.diff
Thu, Apr 3, 2:11 AM
Unknown Object (File)
Mon, Mar 24, 10:38 AM
Unknown Object (File)
Fri, Mar 21, 8:11 AM
Unknown Object (File)
Tue, Mar 18, 11:35 PM
Unknown Object (File)
Fri, Mar 14, 1:01 PM
Unknown Object (File)
Tue, Mar 11, 11:49 AM
Unknown Object (File)
Tue, Mar 4, 11:41 PM
Unknown Object (File)
Mar 3 2025, 6:24 AM
View All 96 Files
Subscribers
ashoat
kamil
tomek

Details

Reviewers
kamil
marcin
Commits
rCOMM9d2b6b4ad0aa: [lib] Implement sending WebPush notifs using Tunnelbroker
Summary

Client code to send notif - only updating types to allow this.
Added a more general TunnelbrokerNotif union type to avoid extending unions in the callsites.

Depends on D12896

Test Plan

Tested together with @kamil, using the following code:

const notif: PlainTextWebNotification = {
  id: uuid.v4(),
  body: 'body hello',
  title: 'notif from TB',
  threadID: '123',
};
const tbNotif: TunnelbrokerWebPushNotif = {
  type: 'WebPushNotif',
    clientMessageID: uuid.v4(),
    deviceID: '*******************************************',
    payload: JSON.stringify(notif),
};
try {
  console.log('starting');
  await sendNotif(tbNotif);
  console.log('done');
} catch (e) {
  console.log(e);
}

Successfully received notif on Firefox, Chrome and Safari

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
9 lines
types/
tunnelbroker/
11 lines

Diff 42892

View Options

lib/tunnelbroker/tunnelbroker-context.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { specialRoles } from 'lib/permissions/special-roles.js'; import { specialRoles } from 'lib/permissions/special-roles.js';
import { getAllThreadPermissions } from 'lib/permissions/thread-permissions.js'; import { getAllThreadPermissions } from 'lib/permissions/thread-permissions.js';
import { import {
rawThreadInfoFromServerThreadInfo, rawThreadInfoFromServerThreadInfo,
getContainingThreadID, getContainingThreadID,
getCommunity, getCommunity,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import {
FUTURE_CODE_VERSION,
hasMinCodeVersion,
} from 'lib/shared/version-utils.js';
import type { AvatarDBContent, ClientAvatar } from 'lib/types/avatar-types.js'; import type { AvatarDBContent, ClientAvatar } from 'lib/types/avatar-types.js';
import type { RawMessageInfo, MessageInfo } from 'lib/types/message-types.js'; import type { RawMessageInfo, MessageInfo } from 'lib/types/message-types.js';
import type { RawThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { RawThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import { threadTypes, type ThreadType } from 'lib/types/thread-types-enum.js'; import { threadTypes, type ThreadType } from 'lib/types/thread-types-enum.js';
import { import {
type ServerThreadInfo, type ServerThreadInfo,
type MixedRawThreadInfos, type MixedRawThreadInfos,
type LegacyRawThreadInfo, type LegacyRawThreadInfo,
▲ Show 20 Lines • Show All 259 Lines • ▼ Show 20 Lines): FetchThreadInfosResult {
}); });
const codeVersionBelow283 = !hasMinCodeVersion(viewer.platformDetails, { const codeVersionBelow283 = !hasMinCodeVersion(viewer.platformDetails, {
native: 285, native: 285,
}); });
const minimallyEncodedPermissionsSupported = hasMinCodeVersion( const minimallyEncodedPermissionsSupported = hasMinCodeVersion(
viewer.platformDetails, viewer.platformDetails,
{ native: 301, web: 56 }, { native: 301, web: 56 },
); );
const futureCodeVersion = hasMinCodeVersion(viewer.platformDetails, {
native: FUTURE_CODE_VERSION,
web: FUTURE_CODE_VERSION,
majorDesktop: FUTURE_CODE_VERSION,
});
const threadInfos: { const threadInfos: {
[string]: LegacyRawThreadInfo | RawThreadInfo, [string]: LegacyRawThreadInfo | RawThreadInfo,
} = {}; } = {};
for (const threadID in serverResult.threadInfos) { for (const threadID in serverResult.threadInfos) {
const serverThreadInfo = serverResult.threadInfos[threadID]; const serverThreadInfo = serverResult.threadInfos[threadID];
const threadInfo = rawThreadInfoFromServerThreadInfo( const threadInfo = rawThreadInfoFromServerThreadInfo(
serverThreadInfo, serverThreadInfo,
viewerID, viewerID,
{ {
filterThreadEditAvatarPermission: codeVersionBelow213, filterThreadEditAvatarPermission: codeVersionBelow213,
excludePinInfo: codeVersionBelow209, excludePinInfo: codeVersionBelow209,
filterManageInviteLinksPermission: codeVersionBelow221, filterManageInviteLinksPermission: codeVersionBelow221,
filterVoicedInAnnouncementChannelsPermission: codeVersionBelow283, filterVoicedInAnnouncementChannelsPermission: codeVersionBelow283,
minimallyEncodePermissions: minimallyEncodedPermissionsSupported, minimallyEncodePermissions: minimallyEncodedPermissionsSupported,
includeSpecialRoleFieldInRoles: futureCodeVersion,
}, },
); );
if (threadInfo) { if (threadInfo) {
threadInfos[threadID] = threadInfo; threadInfos[threadID] = threadInfo;
} }
} }
return { threadInfos }; return { threadInfos };
} }
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

lib/types/tunnelbroker/messages.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { specialRoles } from 'lib/permissions/special-roles.js'; import { specialRoles } from 'lib/permissions/special-roles.js';
import { getAllThreadPermissions } from 'lib/permissions/thread-permissions.js'; import { getAllThreadPermissions } from 'lib/permissions/thread-permissions.js';
import { import {
rawThreadInfoFromServerThreadInfo, rawThreadInfoFromServerThreadInfo,
getContainingThreadID, getContainingThreadID,
getCommunity, getCommunity,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import {
FUTURE_CODE_VERSION,
hasMinCodeVersion,
} from 'lib/shared/version-utils.js';
import type { AvatarDBContent, ClientAvatar } from 'lib/types/avatar-types.js'; import type { AvatarDBContent, ClientAvatar } from 'lib/types/avatar-types.js';
import type { RawMessageInfo, MessageInfo } from 'lib/types/message-types.js'; import type { RawMessageInfo, MessageInfo } from 'lib/types/message-types.js';
import type { RawThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { RawThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import { threadTypes, type ThreadType } from 'lib/types/thread-types-enum.js'; import { threadTypes, type ThreadType } from 'lib/types/thread-types-enum.js';
import { import {
type ServerThreadInfo, type ServerThreadInfo,
type MixedRawThreadInfos, type MixedRawThreadInfos,
type LegacyRawThreadInfo, type LegacyRawThreadInfo,
▲ Show 20 Lines • Show All 259 Lines • ▼ Show 20 Lines): FetchThreadInfosResult {
}); });
const codeVersionBelow283 = !hasMinCodeVersion(viewer.platformDetails, { const codeVersionBelow283 = !hasMinCodeVersion(viewer.platformDetails, {
native: 285, native: 285,
}); });
const minimallyEncodedPermissionsSupported = hasMinCodeVersion( const minimallyEncodedPermissionsSupported = hasMinCodeVersion(
viewer.platformDetails, viewer.platformDetails,
{ native: 301, web: 56 }, { native: 301, web: 56 },
); );
const futureCodeVersion = hasMinCodeVersion(viewer.platformDetails, {
native: FUTURE_CODE_VERSION,
web: FUTURE_CODE_VERSION,
majorDesktop: FUTURE_CODE_VERSION,
});
const threadInfos: { const threadInfos: {
[string]: LegacyRawThreadInfo | RawThreadInfo, [string]: LegacyRawThreadInfo | RawThreadInfo,
} = {}; } = {};
for (const threadID in serverResult.threadInfos) { for (const threadID in serverResult.threadInfos) {
const serverThreadInfo = serverResult.threadInfos[threadID]; const serverThreadInfo = serverResult.threadInfos[threadID];
const threadInfo = rawThreadInfoFromServerThreadInfo( const threadInfo = rawThreadInfoFromServerThreadInfo(
serverThreadInfo, serverThreadInfo,
viewerID, viewerID,
{ {
filterThreadEditAvatarPermission: codeVersionBelow213, filterThreadEditAvatarPermission: codeVersionBelow213,
excludePinInfo: codeVersionBelow209, excludePinInfo: codeVersionBelow209,
filterManageInviteLinksPermission: codeVersionBelow221, filterManageInviteLinksPermission: codeVersionBelow221,
filterVoicedInAnnouncementChannelsPermission: codeVersionBelow283, filterVoicedInAnnouncementChannelsPermission: codeVersionBelow283,
minimallyEncodePermissions: minimallyEncodedPermissionsSupported, minimallyEncodePermissions: minimallyEncodedPermissionsSupported,
includeSpecialRoleFieldInRoles: futureCodeVersion,
}, },
); );
if (threadInfo) { if (threadInfo) {
threadInfos[threadID] = threadInfo; threadInfos[threadID] = threadInfo;
} }
} }
return { threadInfos }; return { threadInfos };
} }
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines