Paths

Table of Contentst

Differential D13050

Extract logic of pushInfo -> usersToCollapsableNotifInfo to lib and use for client-based notifs
ClosedPublic
Actions

Authored by marcin on Aug 12 2024, 6:53 AM.

Tags

None

Referenced Files

	F3507015: D13050.diff
	Fri, Dec 20, 7:01 PM

	Unknown Object (File)
	Mon, Dec 16, 5:10 AM

	Unknown Object (File)
	Nov 14 2024, 1:02 PM

	Unknown Object (File)
	Nov 14 2024, 12:59 PM

	Unknown Object (File)
	Oct 22 2024, 10:44 AM

	Unknown Object (File)
	Oct 22 2024, 10:19 AM

	Unknown Object (File)
	Oct 22 2024, 10:19 AM

	Unknown Object (File)
	Oct 22 2024, 10:19 AM

View All 69 Files

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMM7c083bf2596e: Extract logic of pushInfo -> usersToCollapsableNotifInfo to lib and use for…

Summary

This differential extracts teh logic that groups notifications message infos by collapse key to lib. This is necessary to have working e2ee notifs for sidebar creation. Without this work we would call notificationsTexts on CREATE_SIDEBAR message data and this crashes the app.

Test Plan

For now test that keyserver notifs are not regressed by this diff.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Aug 12 2024, 6:53 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 12 2024, 6:53 AM

marcin added a parent revision: D13048: Implement utilities to go from RawMessageInfo to MessageData.Aug 12 2024, 6:53 AM

marcin added a child revision: D13051: Update useProcessDMOperation to enable sending E2EE notifs.Aug 12 2024, 6:57 AM

Harbormaster completed remote builds in B31046: Diff 43310.Aug 12 2024, 8:08 AM

marcin requested review of this revision.Aug 12 2024, 8:08 AM

marcin added a parent revision: D13010: Update db ops reducer to process notiications creation data.Aug 20 2024, 7:31 AM

marcin removed a parent revision: D13048: Implement utilities to go from RawMessageInfo to MessageData.

marcin removed a child revision: D13051: Update useProcessDMOperation to enable sending E2EE notifs.

marcin added a child revision: D13052: [lib] Split add members spec.Aug 20 2024, 7:42 AM

tomek removed a child revision: D13052: [lib] Split add members spec.Aug 20 2024, 9:28 AM

marcin added a child revision: D13052: [lib] Split add members spec.Aug 20 2024, 1:16 PM

marcin edited child revisions, added: D13121: Implement method to go from DMOperation -> [MessageData] for each dm op spec; removed: D13052: [lib] Split add members spec.Aug 21 2024, 4:19 AM

Reorder the stack

marcin added a parent revision: D12882: Implement sending E2EE notification from the client.Aug 21 2024, 10:09 AM

marcin removed a parent revision: D13010: Update db ops reducer to process notiications creation data.

Harbormaster completed remote builds in B31201: Diff 43555.Aug 21 2024, 10:24 AM

tomek accepted this revision.Aug 27 2024, 12:19 AM

tomek added inline comments.

keyserver/src/fetchers/message-fetchers.js
134–137 ↗	(On Diff #43555)	Can we avoid having a function that modifies its arguments? This is really bad for maintenance.

This revision is now accepted and ready to land.Aug 27 2024, 12:19 AM

Make mergeUserToCollapsableInfo pure.

Harbormaster completed remote builds in B31289: Diff 43681.Aug 27 2024, 7:10 AM

Rebase before landing

Harbormaster completed remote builds in B31304: Diff 43705.Aug 27 2024, 11:12 AM

Closed by commit rCOMM7c083bf2596e: Extract logic of pushInfo -> usersToCollapsableNotifInfo to lib and use for… (authored by Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local>). · Explain WhyAug 27 2024, 11:30 AM

This revision was automatically updated to reflect the committed changes.

Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local> added a commit: rCOMM7c083bf2596e: Extract logic of pushInfo -> usersToCollapsableNotifInfo to lib and use for….

ashoat added inline comments.Sep 6 2024, 9:59 AM

lib/push/send-utils.js
254–257	Should these inputs be read-only?
300–303	Should these inputs be read-only?

marcin mentioned this in D13271: Fix input types from D13050.Sep 9 2024, 6:23 AM

marcin added inline comments.Sep 9 2024, 6:33 AM

lib/push/send-utils.js
254–257	Good catch. Created: https://phab.comm.dev/D13271 to fix.

marcin mentioned this in rCOMM0e2412f00c19: Fix input types from D13050.Sep 11 2024, 5:17 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

message-fetchers.js

71 lines

push/

8 lines

lib/

push/

104 lines

Diff 43712

keyserver/src/fetchers/message-fetchers.js

Loading...

keyserver/src/push/send.js

Loading...

lib/push/send-utils.js

Loading...