Page MenuHomePhabricator
Differential D13106

[lib] Don't prune messages from thick threads
ClosedPublic
Actions

Authored by tomek on Aug 19 2024, 5:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 8:58 AM
Unknown Object (File)
Mon, Mar 31, 1:21 AM
Unknown Object (File)
Mar 11 2025, 3:43 PM
Unknown Object (File)
Mar 8 2025, 5:10 PM
Unknown Object (File)
Mar 8 2025, 5:10 PM
Unknown Object (File)
Mar 8 2025, 5:10 PM
Unknown Object (File)
Mar 8 2025, 5:10 PM
Unknown Object (File)
Mar 6 2025, 6:43 AM
View All 72 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMM4cdc2ad83d55: [lib] Don't prune messages from thick threads
Summary

Prune messages only from Redux. It is achieved by generating DB ops only for thin threads.

https://linear.app/comm/issue/ENG-9037/old-messages-in-thick-threads-arent-loading-on-web
https://linear.app/comm/issue/ENG-8700/dont-create-ops-when-pruning-dm-messages

Test Plan

Create a thick thread with 100 messages. Refresh the web app - which causes pruning. Refresh it once again - only 20 messages should be displayed in the UI. Check if setClientDBStoreActionType action payload contains all 100 messages.

Diff Detail

Repository
rCOMM Comm
Branch
messages-pruning
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
reducers/
56 lines

Diff 43449

View Options

lib/reducers/message-reducer.js

pub mod auth; pub mod auth;
pub mod auth_service;
pub mod multipart; pub mod multipart;
use crate::tools::BoxedError; use crate::tools::BoxedError;
use actix_cors::Cors; use actix_cors::Cors;
use actix_web::web::Bytes; use actix_web::web::Bytes;
use futures_core::Stream; use futures_core::Stream;
pub fn cors_config(is_sandbox: bool) -> Cors { pub fn cors_config(is_sandbox: bool) -> Cors {
Show All 25 Lines