[lib] Don't prune messages from thick threads
ClosedPublic
Actions

Authored by tomek on Aug 19 2024, 5:10 AM.

Details

Reviewers

kamil
inka

Commits

rCOMM4cdc2ad83d55: [lib] Don't prune messages from thick threads

Summary

Prune messages only from Redux. It is achieved by generating DB ops only for thin threads.

https://linear.app/comm/issue/ENG-9037/old-messages-in-thick-threads-arent-loading-on-web
https://linear.app/comm/issue/ENG-8700/dont-create-ops-when-pruning-dm-messages

Test Plan

Create a thick thread with 100 messages. Refresh the web app - which causes pruning. Refresh it once again - only 20 messages should be displayed in the UI. Check if setClientDBStoreActionType action payload contains all 100 messages.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Aug 19 2024, 5:10 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 19 2024, 5:10 AM

Harbormaster completed remote builds in B31136: Diff 43449.Aug 19 2024, 5:27 AM

tomek requested review of this revision.Aug 19 2024, 5:27 AM

tomek added a child revision: D13133: [native] Rename `getAllMessages` method.Aug 21 2024, 10:13 AM

kamil accepted this revision.Aug 23 2024, 8:35 AM

This revision is now accepted and ready to land.Aug 23 2024, 8:35 AM

Closed by commit rCOMM4cdc2ad83d55: [lib] Don't prune messages from thick threads (authored by tomek). · Explain WhyAug 27 2024, 8:01 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM4cdc2ad83d55: [lib] Don't prune messages from thick threads.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

message-reducer.js

56 lines

Diff 43684

View Options

lib/reducers/message-reducer.js

[lib] Don't prune messages from thick threadsClosedPublicActions