Page MenuHomePhabricator

[web][native] Extract common fetching logic
ClosedPublic

Authored by tomek on Aug 23 2024, 5:03 AM.
Tags
None
Referenced Files
F3332650: D13147.id43673.diff
Thu, Nov 21, 12:44 AM
Unknown Object (File)
Sun, Nov 17, 9:08 AM
Unknown Object (File)
Fri, Nov 8, 10:37 PM
Unknown Object (File)
Fri, Nov 8, 1:44 PM
Unknown Object (File)
Fri, Nov 8, 12:22 PM
Unknown Object (File)
Fri, Oct 25, 6:51 PM
Unknown Object (File)
Oct 22 2024, 1:18 PM
Unknown Object (File)
Oct 22 2024, 8:33 AM
Subscribers

Details

Summary

This logic is the same on both platforms and can be reused. Later in the stack I'm going to introduce the logic for thick thread fetching to this hook.

https://linear.app/comm/issue/ENG-8706/modify-message-lists-to-call-the-new-function

Depends on D13142

Test Plan

Tested on both native and web whether threads with less than 20 messages are displayed correctly and fetching all the messages, in batches, works for longer threads.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek requested review of this revision.Aug 23 2024, 5:20 AM
kamil added inline comments.
lib/actions/message-actions.js
548 ↗(On Diff #43604)

I would put this into lib/shared/message-utils.js but not feeling strongly

This revision is now accepted and ready to land.Aug 26 2024, 3:49 AM
This revision was automatically updated to reflect the committed changes.