Page MenuHomePhabricator

Return single curve25519 string from NotificationsInboundKeysProvider
ClosedPublic

Authored by marcin on Aug 26 2024, 4:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 5:03 PM
Unknown Object (File)
Wed, Dec 18, 5:03 PM
Unknown Object (File)
Wed, Dec 18, 5:00 PM
Unknown Object (File)
Nov 20 2024, 12:02 PM
Unknown Object (File)
Nov 10 2024, 12:43 PM
Unknown Object (File)
Nov 9 2024, 3:34 PM
Unknown Object (File)
Nov 8 2024, 11:23 PM
Unknown Object (File)
Nov 3 2024, 9:08 PM
Subscribers

Details

Summary

This differential returns only curve25519 key string from native code and creates JSON in C++ with folly instead of creating JSON in native code. The rieason for this change is that we saw issues with the content of the JSON returned from Java - Android app was unable to create session as inbound since sender identity key was corrupted. This change fixed the issue.

Test Plan
  1. Before this diff creating notifs session with Android device as inboud would fail each (> 90%) of the times.
  2. After this diff it always works.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 28 2024, 9:41 AM