Page MenuHomePhabricator
Differential D13181

[lib] update `creatorID` -> `unread` in `CreateThickRawThreadInfoInput`
ClosedPublic
Actions

Authored by kamil on Aug 27 2024, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 27, 7:34 AM
Unknown Object (File)
Sun, Mar 9, 7:34 AM
Unknown Object (File)
Sun, Mar 9, 7:34 AM
Unknown Object (File)
Sun, Mar 9, 7:34 AM
Unknown Object (File)
Sun, Mar 9, 7:34 AM
Unknown Object (File)
Feb 22 2025, 4:41 AM
Unknown Object (File)
Jan 21 2025, 10:36 PM
Unknown Object (File)
Jan 15 2025, 7:49 AM
View All 53 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM097977552fcf: [lib] update `creatorID` -> `unread` in `CreateThickRawThreadInfoInput`
Summary

ENG-8568

We need to use CreateThickRawThreadInfoInput when creating ADD_VIEWER_TO_THREAD_MEMBERS, where it's complicated to retrieve creatorID.

creatorID is used only for computing unread, that being said we can simplify this.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Branch
logic-2
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
2 lines
6 lines
types/
4 lines

Diff 43716

View Options

lib/shared/dm-ops/create-sidebar-spec.js

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;
View Options

lib/shared/dm-ops/create-thread-spec.js

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;
View Options

lib/types/dm-ops.js

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;