Page MenuHomePhabricator
Differential D13186

[lib][native] update `useEditMessage` return type
ClosedPublic
Actions

Authored by kamil on Aug 28 2024, 2:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 4 2025, 7:16 AM
Unknown Object (File)
Mar 4 2025, 7:16 AM
Unknown Object (File)
Mar 4 2025, 7:16 AM
Unknown Object (File)
Mar 4 2025, 7:15 AM
Unknown Object (File)
Mar 4 2025, 7:15 AM
Unknown Object (File)
Mar 2 2025, 3:03 PM
Unknown Object (File)
Mar 2 2025, 3:02 PM
Unknown Object (File)
Feb 16 2025, 1:55 AM
View All 71 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM6cc6e90afda0: [lib][native] update `useEditMessage` return type
Summary

ENG-8976;

SendEditMessageResult is used only in dispatchActionPromise, other than that we only care about success/failure.

With that change, we're able to use this hook also for DMs where SendEditMessageResult is not existing.

Test Plan

Editing still works

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Aug 28 2024, 2:53 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 2:53 AM
kamil added a child revision: D13187: [lib] add editing DM messages.Aug 28 2024, 2:56 AM
Harbormaster completed remote builds in B31314: Diff 43722.Aug 28 2024, 3:12 AM
kamil published this revision for review.Aug 28 2024, 3:59 AM
tomek accepted this revision.Aug 28 2024, 5:34 AM
tomek added inline comments.
lib/shared/edit-messages-utils.js
28–48 ↗(On Diff #43722)

We can simplify the syntax

This revision is now accepted and ready to land.Aug 28 2024, 5:34 AM
kamil added a parent revision: D13193: [lib] make it possible to send DM ops to all thread members.Aug 28 2024, 6:24 AM
kamil updated this revision to Diff 43744.Aug 28 2024, 6:37 AM

simplify syntax

Harbormaster completed remote builds in B31334: Diff 43744.Aug 28 2024, 6:56 AM
Closed by commit rCOMM6cc6e90afda0: [lib][native] update `useEditMessage` return type (authored by kamil). · Explain WhyAug 28 2024, 8:33 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM6cc6e90afda0: [lib][native] update `useEditMessage` return type.

Revision Contents
Changeset List

PathSize
lib/
shared/
7 lines
native/
chat/
10 lines

Diff 43760

View Options

lib/shared/edit-messages-utils.js

Show All 35 Lines <div className={css.wrapper}>
<TeamProfile <TeamProfile
name="Ashoat Tevosyan" name="Ashoat Tevosyan"
role="Founder" role="Founder"
githubHandle="ashoat" githubHandle="ashoat"
twitterHandle="ashoat" twitterHandle="ashoat"
imageURL={`${assetsCacheURLPrefix}/ashoat.png`} imageURL={`${assetsCacheURLPrefix}/ashoat.png`}
/> />
<TeamProfile <TeamProfile
name="atul"
role="Software Engineer"
githubHandle="atulsmadhugiri"
twitterHandle="atuli0"
imageURL={`${assetsCacheURLPrefix}/atul.jpeg`}
/>
<TeamProfile
name="Varun Dhananjaya" name="Varun Dhananjaya"
role="Software Engineer" role="Software Engineer"
githubHandle="vdhanan" githubHandle="vdhanan"
twitterHandle="_va_run" twitterHandle="_va_run"
imageURL={`${assetsCacheURLPrefix}/varun.jpeg`} imageURL={`${assetsCacheURLPrefix}/varun.jpeg`}
/> />
<TeamProfile <TeamProfile
name="Mark Rafferty" name="William Wang"
role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
/>
<TeamProfile
name="Anunay Kulshrestha"
role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/anunay.jpg`}
/>
<TeamProfile
name="Ginsu Eddy"
role="Software Engineer" role="Software Engineer"
githubHandle="ginsueddy" imageURL={`${assetsCacheURLPrefix}/will.jpg`}
twitterHandle="ginsueddy" githubHandle="wyilio"
imageURL={`${assetsCacheURLPrefix}/ginsu.jpg`}
/> />
<TeamProfile <TeamProfile
name="Rohan Khanderia" name="Yiannis Tselekounis"
role="Software Engineer" role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/rohan.jpg`} imageURL={`${assetsCacheURLPrefix}/yiannis.jpeg`}
githubHandle="RohanK6"
/> />
<TeamProfile <TeamProfile
name="William Wang" name="Mark Rafferty"
role="Software Engineer" role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/will.jpg`} imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
githubHandle="wyilio"
/> />
</div> </div>
</section> </section>
<h2 className={headerClassName}>Team at Software Mansion</h2> <h2 className={headerClassName}>Team at Software Mansion</h2>
<section className={css.teamWrapper}> <section className={css.teamWrapper}>
<TeamProfile <TeamProfile
name="Tomasz Pałys" name="Tomasz Pałys"
role="Software Engineer" role="Software Engineer"
githubHandle="palys-swm" githubHandle="palys-swm"
imageURL={`${assetsCacheURLPrefix}/tomek.png`} imageURL={`${assetsCacheURLPrefix}/tomek.png`}
/> />
<TeamProfile <TeamProfile
name="Marcin Wasowicz"
role="Software Engineer"
githubHandle="marcinwasowicz"
imageURL={`${assetsCacheURLPrefix}/marcin.jpeg`}
/>
<TeamProfile
name="Inka Sokolowska"
role="Software Engineer"
githubHandle="InkaAlicja"
imageURL={`${assetsCacheURLPrefix}/inka.jpg`}
/>
<TeamProfile
name="Kamil Kurowski" name="Kamil Kurowski"
role="Software Engineer" role="Software Engineer"
githubHandle="xsanm" githubHandle="xsanm"
imageURL={`${assetsCacheURLPrefix}/kamil.jpg`} imageURL={`${assetsCacheURLPrefix}/kamil.jpg`}
/> />
<TeamProfile <TeamProfile
name="Michał Gniadek"
role="Software Engineer"
githubHandle="MichalGniadek"
imageURL={`${assetsCacheURLPrefix}/michał.jpg`}
/>
<TeamProfile
name="Bartłomiej Klocek" name="Bartłomiej Klocek"
role="Software Engineer" role="Software Engineer"
githubHandle="barthap" githubHandle="barthap"
twitterHandle="barthap10" twitterHandle="barthap10"
imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`} imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`}
/> />
<TeamProfile <TeamProfile
name="Aleksandra Grzęda" name="Angelika Serwa"
role="Project Manager" role="Software Engineer"
imageURL={`${assetsCacheURLPrefix}/aleksandra.jpg`} githubHandle="graszka22"
imageURL={`${assetsCacheURLPrefix}/angelika.png`}
/> />
<TeamProfile <TeamProfile
name="Monika Kulczyńska" name="Monika Kulczyńska"
role="Project Manager" role="Project Manager"
imageURL={`${assetsCacheURLPrefix}/monika.jpg`} imageURL={`${assetsCacheURLPrefix}/monika.jpg`}
/> />
</section> </section>
</div> </div>
); );
} }
export default Team; export default Team;
View Options

native/chat/chat-input-bar.react.js

Show All 35 Lines <div className={css.wrapper}>
<TeamProfile <TeamProfile
name="Ashoat Tevosyan" name="Ashoat Tevosyan"
role="Founder" role="Founder"
githubHandle="ashoat" githubHandle="ashoat"
twitterHandle="ashoat" twitterHandle="ashoat"
imageURL={`${assetsCacheURLPrefix}/ashoat.png`} imageURL={`${assetsCacheURLPrefix}/ashoat.png`}
/> />
<TeamProfile <TeamProfile
name="atul"
role="Software Engineer"
githubHandle="atulsmadhugiri"
twitterHandle="atuli0"
imageURL={`${assetsCacheURLPrefix}/atul.jpeg`}
/>
<TeamProfile
name="Varun Dhananjaya" name="Varun Dhananjaya"
role="Software Engineer" role="Software Engineer"
githubHandle="vdhanan" githubHandle="vdhanan"
twitterHandle="_va_run" twitterHandle="_va_run"
imageURL={`${assetsCacheURLPrefix}/varun.jpeg`} imageURL={`${assetsCacheURLPrefix}/varun.jpeg`}
/> />
<TeamProfile <TeamProfile
name="Mark Rafferty" name="William Wang"
role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
/>
<TeamProfile
name="Anunay Kulshrestha"
role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/anunay.jpg`}
/>
<TeamProfile
name="Ginsu Eddy"
role="Software Engineer" role="Software Engineer"
githubHandle="ginsueddy" imageURL={`${assetsCacheURLPrefix}/will.jpg`}
twitterHandle="ginsueddy" githubHandle="wyilio"
imageURL={`${assetsCacheURLPrefix}/ginsu.jpg`}
/> />
<TeamProfile <TeamProfile
name="Rohan Khanderia" name="Yiannis Tselekounis"
role="Software Engineer" role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/rohan.jpg`} imageURL={`${assetsCacheURLPrefix}/yiannis.jpeg`}
githubHandle="RohanK6"
/> />
<TeamProfile <TeamProfile
name="William Wang" name="Mark Rafferty"
role="Software Engineer" role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/will.jpg`} imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
githubHandle="wyilio"
/> />
</div> </div>
</section> </section>
<h2 className={headerClassName}>Team at Software Mansion</h2> <h2 className={headerClassName}>Team at Software Mansion</h2>
<section className={css.teamWrapper}> <section className={css.teamWrapper}>
<TeamProfile <TeamProfile
name="Tomasz Pałys" name="Tomasz Pałys"
role="Software Engineer" role="Software Engineer"
githubHandle="palys-swm" githubHandle="palys-swm"
imageURL={`${assetsCacheURLPrefix}/tomek.png`} imageURL={`${assetsCacheURLPrefix}/tomek.png`}
/> />
<TeamProfile <TeamProfile
name="Marcin Wasowicz"
role="Software Engineer"
githubHandle="marcinwasowicz"
imageURL={`${assetsCacheURLPrefix}/marcin.jpeg`}
/>
<TeamProfile
name="Inka Sokolowska"
role="Software Engineer"
githubHandle="InkaAlicja"
imageURL={`${assetsCacheURLPrefix}/inka.jpg`}
/>
<TeamProfile
name="Kamil Kurowski" name="Kamil Kurowski"
role="Software Engineer" role="Software Engineer"
githubHandle="xsanm" githubHandle="xsanm"
imageURL={`${assetsCacheURLPrefix}/kamil.jpg`} imageURL={`${assetsCacheURLPrefix}/kamil.jpg`}
/> />
<TeamProfile <TeamProfile
name="Michał Gniadek"
role="Software Engineer"
githubHandle="MichalGniadek"
imageURL={`${assetsCacheURLPrefix}/michał.jpg`}
/>
<TeamProfile
name="Bartłomiej Klocek" name="Bartłomiej Klocek"
role="Software Engineer" role="Software Engineer"
githubHandle="barthap" githubHandle="barthap"
twitterHandle="barthap10" twitterHandle="barthap10"
imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`} imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`}
/> />
<TeamProfile <TeamProfile
name="Aleksandra Grzęda" name="Angelika Serwa"
role="Project Manager" role="Software Engineer"
imageURL={`${assetsCacheURLPrefix}/aleksandra.jpg`} githubHandle="graszka22"
imageURL={`${assetsCacheURLPrefix}/angelika.png`}
/> />
<TeamProfile <TeamProfile
name="Monika Kulczyńska" name="Monika Kulczyńska"
role="Project Manager" role="Project Manager"
imageURL={`${assetsCacheURLPrefix}/monika.jpg`} imageURL={`${assetsCacheURLPrefix}/monika.jpg`}
/> />
</section> </section>
</div> </div>
); );
} }
export default Team; export default Team;