Page MenuHomePhabricator
Differential D13197

[lib] implement adding thread members for DMs
ClosedPublic
Actions

Authored by kamil on Aug 28 2024, 8:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 12:53 AM
Unknown Object (File)
Mon, Nov 18, 9:35 AM
Unknown Object (File)
Fri, Nov 8, 3:47 PM
Unknown Object (File)
Fri, Nov 8, 1:11 AM
Unknown Object (File)
Fri, Nov 8, 12:55 AM
Unknown Object (File)
Thu, Nov 7, 11:46 PM
Unknown Object (File)
Thu, Nov 7, 11:26 PM
Unknown Object (File)
Thu, Nov 7, 11:25 PM
View All 66 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM80bd999464a2: [lib] implement adding thread members for DMs
Summary

ENG-8568

This hook which wraps two needed operations together, add_viewer_to_thread_members and add_members.

Doing this in parallel, not at once is bad, created a task to fix this: ENG-9103, as this is complex change.

Depends on D13182, D13193

Test Plan

Tested later in the stack

Diff Detail

Repository
rCOMM Comm
Branch
logic-5
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Aug 28 2024, 8:37 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 8:37 AM
kamil updated this revision to Diff 43766.Aug 28 2024, 8:45 AM

update recipients

Harbormaster failed remote builds in B31347: Diff 43765!Aug 28 2024, 8:46 AM
kamil added a child revision: D13198: [native] implement adding thread members in `AddUsersModal`.Aug 28 2024, 8:47 AM
Harbormaster failed remote builds in B31348: Diff 43766!Aug 28 2024, 8:51 AM
Harbormaster completed remote builds in B31348: Diff 43766.Aug 28 2024, 9:03 AM
kamil published this revision for review.Aug 28 2024, 9:33 AM
kamil edited the summary of this revision. (Show Details)
tomek accepted this revision.Aug 28 2024, 9:56 AM
tomek added inline comments.
lib/shared/dm-ops/dm-op-utils.js
172
222

Maybe await?

This revision is now accepted and ready to land.Aug 28 2024, 9:56 AM
kamil updated this revision to Diff 43779.Aug 29 2024, 12:21 AM

address review

Harbormaster completed remote builds in B31359: Diff 43779.Aug 29 2024, 12:46 AM
Closed by commit rCOMM80bd999464a2: [lib] implement adding thread members for DMs (authored by kamil). · Explain WhyAug 29 2024, 1:16 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM80bd999464a2: [lib] implement adding thread members for DMs.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
117 lines

Diff 43766

View Options

lib/shared/dm-ops/dm-op-utils.js

Loading...