Only remove the editor when the operation is more recent than the timestamp.
https://linear.app/comm/issue/ENG-9116/update-leavethreadspec
Depends on D13219
Details
Details
- Reviewers
kamil inka - Commits
- rCOMM1e240b7e30c7: [lib] Check the timestamps when leaving a thread
Create a thread, add some members, and remove some. Check if the timestamps behave correctly, and the membership is correct.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/shared/dm-ops/leave-thread-spec.js | ||
|---|---|---|
| 73 ↗ | (On Diff #43834) | We seem to prioritise removing a user over adding a user. I would do it the other way around because it's easier to remove someone than it is to add them, but up to you. |
| 74–77 ↗ | (On Diff #43834) | We are updating the timestamp even if isMember > time. Should we early return here like in previous diffs? |