Differential D13234

[lib] Check the timestamps when updating thread subscription
ClosedPublic
Actions

Authored by tomek on Tue, Sep 3, 9:58 AM.

Tags

None

Referenced Files

	F2737721: D13234.diff
	Tue, Sep 17, 7:23 PM

	Unknown Object (File)
	Sun, Sep 15, 3:21 PM

	Unknown Object (File)
	Sun, Sep 15, 2:40 PM

	Unknown Object (File)
	Sun, Sep 15, 2:07 PM

	Unknown Object (File)
	Sun, Sep 15, 2:18 AM

	Unknown Object (File)
	Sun, Sep 15, 1:10 AM

	Unknown Object (File)
	Fri, Sep 13, 12:52 PM

	Unknown Object (File)
	Thu, Sep 12, 12:42 PM

View All 20 Files

Subscribers

Details

Reviewers

kamil
inka
marcin

Commits

rCOMM9ede5407abc5: [lib] Check the timestamps when updating thread subscription

Summary

Check the timestamp and don't update the subscription when the timestamp is more recent than the operation.

https://linear.app/comm/issue/ENG-9119/update-changethreadsubscriptionspec

Depends on D13233

Test Plan

Perform a couple of thread subscription operations and check if the state is correct.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Tue, Sep 3, 9:58 AM

Herald added a subscriber: ashoat. · View Herald TranscriptTue, Sep 3, 9:58 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Sep 3, 10:02 AM

Harbormaster failed remote builds in B31422: Diff 43877!

Harbormaster completed remote builds in B31422: Diff 43877.Tue, Sep 3, 10:15 AM

tomek requested review of this revision.Tue, Sep 3, 10:15 AM

tomek added a child revision: D13240: [lib] Check the timestamps when updating read status.Wed, Sep 4, 7:28 AM

tomek added a child revision: D13241: [lib] Check the timestamps when updating read status for all the specs.Wed, Sep 4, 9:58 AM

marcin accepted this revision.Thu, Sep 5, 12:46 AM

This revision is now accepted and ready to land.Thu, Sep 5, 12:46 AM

tomek removed a child revision: D13240: [lib] Check the timestamps when updating read status.Thu, Sep 5, 3:12 AM

Closed by commit rCOMM9ede5407abc5: [lib] Check the timestamps when updating thread subscription (authored by tomek). · Explain WhyFri, Sep 6, 8:10 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM9ede5407abc5: [lib] Check the timestamps when updating thread subscription.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

change-thread-subscription.js

17 lines

Diff 43938

lib/shared/dm-ops/change-thread-subscription.js

Loading...