Page MenuHomePhabricator
Differential D13219

[lib] Include `timestamps` inside `CreateThickRawThreadInfoInput`
ClosedPublic
Actions

Authored by tomek on Mon, Sep 2, 7:41 AM.
Tags
None
Referenced Files
F2736734: D13219.id43935.diff
Tue, Sep 17, 5:07 PM
Unknown Object (File)
Mon, Sep 16, 2:13 PM
Unknown Object (File)
Mon, Sep 16, 5:32 AM
Unknown Object (File)
Sun, Sep 15, 7:42 PM
Unknown Object (File)
Sat, Sep 14, 11:35 PM
Unknown Object (File)
Sat, Sep 14, 6:18 PM
Unknown Object (File)
Fri, Sep 13, 11:27 PM
Unknown Object (File)
Thu, Sep 12, 10:24 AM
View All 34 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMM0f069ef7f861: [lib] Include `timestamps` inside `CreateThickRawThreadInfoInput`
Summary

When a user is added to a thread, they should get the correct timestamps instead of assuming that thread creation time or operation time are correct.

https://linear.app/comm/issue/ENG-9124/send-timestamps-in-existingthreaddetails

Depends on D13218

Test Plan

Create an operation with the creation of a new thread. Check if the timestamps are correct.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Mon, Sep 2, 7:41 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMon, Sep 2, 7:41 AM
tomek updated this revision to Diff 43832.Mon, Sep 2, 7:42 AM

Merge imports

Harbormaster completed remote builds in B31386: Diff 43831.Mon, Sep 2, 7:57 AM
Harbormaster completed remote builds in B31387: Diff 43832.
tomek requested review of this revision.Mon, Sep 2, 7:58 AM
tomek added a child revision: D13220: [lib] Check the timestamps when leaving a thread.Mon, Sep 2, 8:53 AM
inka accepted this revision.Tue, Sep 3, 3:59 AM
This revision is now accepted and ready to land.Tue, Sep 3, 3:59 AM
tomek mentioned this in D13218: [lib] Check the timestamps when adding the viewer to thread members.Thu, Sep 5, 3:15 AM
tomek updated this revision to Diff 43892.Thu, Sep 5, 3:25 AM

Pass timestamps directly to createThickRawThreadInfo

Harbormaster completed remote builds in B31434: Diff 43892.Thu, Sep 5, 3:42 AM
Closed by commit rCOMM0f069ef7f861: [lib] Include `timestamps` inside `CreateThickRawThreadInfoInput` (authored by tomek). · Explain WhyFri, Sep 6, 8:10 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM0f069ef7f861: [lib] Include `timestamps` inside `CreateThickRawThreadInfoInput`.

Revision Contents
Changeset List

Diff 43935

View Options

lib/shared/dm-ops/add-viewer-to-thread-members-spec.js

Loading...
View Options

lib/shared/dm-ops/create-sidebar-spec.js

Loading...
View Options

lib/shared/dm-ops/create-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/dm-op-utils.js

Loading...
View Options

lib/shared/dm-ops/join-thread-spec.js

Loading...
View Options

lib/types/dm-ops.js

Loading...