Page MenuHomePhabricator
Differential D13219

[lib] Include `timestamps` inside `CreateThickRawThreadInfoInput`
ClosedPublic
Actions

Authored by tomek on Sep 2 2024, 7:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 10, 6:21 PM
Unknown Object (File)
Wed, Mar 5, 4:02 AM
Unknown Object (File)
Wed, Mar 5, 4:02 AM
Unknown Object (File)
Wed, Mar 5, 4:02 AM
Unknown Object (File)
Wed, Mar 5, 4:02 AM
Unknown Object (File)
Wed, Mar 5, 4:01 AM
Unknown Object (File)
Wed, Mar 5, 4:01 AM
Unknown Object (File)
Feb 27 2025, 8:40 AM
View All 73 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMM0f069ef7f861: [lib] Include `timestamps` inside `CreateThickRawThreadInfoInput`
Summary

When a user is added to a thread, they should get the correct timestamps instead of assuming that thread creation time or operation time are correct.

https://linear.app/comm/issue/ENG-9124/send-timestamps-in-existingthreaddetails

Depends on D13218

Test Plan

Create an operation with the creation of a new thread. Check if the timestamps are correct.

Diff Detail

Repository
rCOMM Comm
Branch
timestamps
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Sep 2 2024, 7:41 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 2 2024, 7:41 AM
tomek updated this revision to Diff 43832.Sep 2 2024, 7:42 AM

Merge imports

Harbormaster completed remote builds in B31386: Diff 43831.Sep 2 2024, 7:57 AM
Harbormaster completed remote builds in B31387: Diff 43832.
tomek requested review of this revision.Sep 2 2024, 7:58 AM
tomek added a child revision: D13220: [lib] Check the timestamps when leaving a thread.Sep 2 2024, 8:53 AM
inka accepted this revision.Sep 3 2024, 3:59 AM
This revision is now accepted and ready to land.Sep 3 2024, 3:59 AM
tomek mentioned this in D13218: [lib] Check the timestamps when adding the viewer to thread members.Sep 5 2024, 3:15 AM
tomek updated this revision to Diff 43892.Sep 5 2024, 3:25 AM

Pass timestamps directly to createThickRawThreadInfo

Harbormaster completed remote builds in B31434: Diff 43892.Sep 5 2024, 3:42 AM
Closed by commit rCOMM0f069ef7f861: [lib] Include `timestamps` inside `CreateThickRawThreadInfoInput` (authored by tomek). · Explain WhySep 6 2024, 8:10 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM0f069ef7f861: [lib] Include `timestamps` inside `CreateThickRawThreadInfoInput`.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
2 lines
4 lines
1 line
types/
6 lines

Diff 43832

View Options

lib/shared/dm-ops/create-sidebar-spec.js

Show All 31 Lines egress {
to_port = 0 to_port = 0
protocol = "-1" protocol = "-1"
cidr_blocks = ["0.0.0.0/0"] cidr_blocks = ["0.0.0.0/0"]
} }
} }
# MariaDB RDS Instance # MariaDB RDS Instance
resource "aws_db_instance" "mariadb" { resource "aws_db_instance" "mariadb" {
allocated_storage = 100 allocated_storage = 100
max_allocated_storage = 3000 max_allocated_storage = 3000
storage_type = "gp3" storage_type = "gp3"
db_name = "mariadb" db_name = "mariadb"
identifier = "mariadb-instance" identifier = "mariadb-instance"
engine = "mariadb" engine = "mariadb"
engine_version = "10.11" engine_version = "10.11"
backup_retention_period = 7
instance_class = var.db_instance_class instance_class = var.db_instance_class
db_subnet_group_name = aws_db_subnet_group.public_db_subnet_group.name db_subnet_group_name = aws_db_subnet_group.public_db_subnet_group.name
vpc_security_group_ids = [aws_security_group.keyserver_mariadb_security_group.id] vpc_security_group_ids = [aws_security_group.keyserver_mariadb_security_group.id]
username = local.mariadb_username username = local.mariadb_username
password = local.mariadb_password password = local.mariadb_password
parameter_group_name = aws_db_parameter_group.mariadb_parameter_group.name parameter_group_name = aws_db_parameter_group.mariadb_parameter_group.name
storage_encrypted = true storage_encrypted = true
publicly_accessible = true publicly_accessible = true
port = local.mariadb_port port = local.mariadb_port
skip_final_snapshot = true skip_final_snapshot = true
} }
# MariaDB Parameter Group # MariaDB Parameter Group
resource "aws_db_parameter_group" "mariadb_parameter_group" { resource "aws_db_parameter_group" "mariadb_parameter_group" {
name = "mariadb-parameter-group" name = "mariadb-parameter-group"
family = "mariadb10.11" family = "mariadb10.11"
parameter { parameter {
▲ Show 20 Lines • Show All 56 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/create-thread-spec.js

Show All 31 Lines egress {
to_port = 0 to_port = 0
protocol = "-1" protocol = "-1"
cidr_blocks = ["0.0.0.0/0"] cidr_blocks = ["0.0.0.0/0"]
} }
} }
# MariaDB RDS Instance # MariaDB RDS Instance
resource "aws_db_instance" "mariadb" { resource "aws_db_instance" "mariadb" {
allocated_storage = 100 allocated_storage = 100
max_allocated_storage = 3000 max_allocated_storage = 3000
storage_type = "gp3" storage_type = "gp3"
db_name = "mariadb" db_name = "mariadb"
identifier = "mariadb-instance" identifier = "mariadb-instance"
engine = "mariadb" engine = "mariadb"
engine_version = "10.11" engine_version = "10.11"
backup_retention_period = 7
instance_class = var.db_instance_class instance_class = var.db_instance_class
db_subnet_group_name = aws_db_subnet_group.public_db_subnet_group.name db_subnet_group_name = aws_db_subnet_group.public_db_subnet_group.name
vpc_security_group_ids = [aws_security_group.keyserver_mariadb_security_group.id] vpc_security_group_ids = [aws_security_group.keyserver_mariadb_security_group.id]
username = local.mariadb_username username = local.mariadb_username
password = local.mariadb_password password = local.mariadb_password
parameter_group_name = aws_db_parameter_group.mariadb_parameter_group.name parameter_group_name = aws_db_parameter_group.mariadb_parameter_group.name
storage_encrypted = true storage_encrypted = true
publicly_accessible = true publicly_accessible = true
port = local.mariadb_port port = local.mariadb_port
skip_final_snapshot = true skip_final_snapshot = true
} }
# MariaDB Parameter Group # MariaDB Parameter Group
resource "aws_db_parameter_group" "mariadb_parameter_group" { resource "aws_db_parameter_group" "mariadb_parameter_group" {
name = "mariadb-parameter-group" name = "mariadb-parameter-group"
family = "mariadb10.11" family = "mariadb10.11"
parameter { parameter {
▲ Show 20 Lines • Show All 56 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/dm-op-utils.js

Show All 31 Lines egress {
to_port = 0 to_port = 0
protocol = "-1" protocol = "-1"
cidr_blocks = ["0.0.0.0/0"] cidr_blocks = ["0.0.0.0/0"]
} }
} }
# MariaDB RDS Instance # MariaDB RDS Instance
resource "aws_db_instance" "mariadb" { resource "aws_db_instance" "mariadb" {
allocated_storage = 100 allocated_storage = 100
max_allocated_storage = 3000 max_allocated_storage = 3000
storage_type = "gp3" storage_type = "gp3"
db_name = "mariadb" db_name = "mariadb"
identifier = "mariadb-instance" identifier = "mariadb-instance"
engine = "mariadb" engine = "mariadb"
engine_version = "10.11" engine_version = "10.11"
backup_retention_period = 7
instance_class = var.db_instance_class instance_class = var.db_instance_class
db_subnet_group_name = aws_db_subnet_group.public_db_subnet_group.name db_subnet_group_name = aws_db_subnet_group.public_db_subnet_group.name
vpc_security_group_ids = [aws_security_group.keyserver_mariadb_security_group.id] vpc_security_group_ids = [aws_security_group.keyserver_mariadb_security_group.id]
username = local.mariadb_username username = local.mariadb_username
password = local.mariadb_password password = local.mariadb_password
parameter_group_name = aws_db_parameter_group.mariadb_parameter_group.name parameter_group_name = aws_db_parameter_group.mariadb_parameter_group.name
storage_encrypted = true storage_encrypted = true
publicly_accessible = true publicly_accessible = true
port = local.mariadb_port port = local.mariadb_port
skip_final_snapshot = true skip_final_snapshot = true
} }
# MariaDB Parameter Group # MariaDB Parameter Group
resource "aws_db_parameter_group" "mariadb_parameter_group" { resource "aws_db_parameter_group" "mariadb_parameter_group" {
name = "mariadb-parameter-group" name = "mariadb-parameter-group"
family = "mariadb10.11" family = "mariadb10.11"
parameter { parameter {
▲ Show 20 Lines • Show All 56 Lines • Show Last 20 Lines
View Options

lib/types/dm-ops.js

Show All 31 Lines egress {
to_port = 0 to_port = 0
protocol = "-1" protocol = "-1"
cidr_blocks = ["0.0.0.0/0"] cidr_blocks = ["0.0.0.0/0"]
} }
} }
# MariaDB RDS Instance # MariaDB RDS Instance
resource "aws_db_instance" "mariadb" { resource "aws_db_instance" "mariadb" {
allocated_storage = 100 allocated_storage = 100
max_allocated_storage = 3000 max_allocated_storage = 3000
storage_type = "gp3" storage_type = "gp3"
db_name = "mariadb" db_name = "mariadb"
identifier = "mariadb-instance" identifier = "mariadb-instance"
engine = "mariadb" engine = "mariadb"
engine_version = "10.11" engine_version = "10.11"
backup_retention_period = 7
instance_class = var.db_instance_class instance_class = var.db_instance_class
db_subnet_group_name = aws_db_subnet_group.public_db_subnet_group.name db_subnet_group_name = aws_db_subnet_group.public_db_subnet_group.name
vpc_security_group_ids = [aws_security_group.keyserver_mariadb_security_group.id] vpc_security_group_ids = [aws_security_group.keyserver_mariadb_security_group.id]
username = local.mariadb_username username = local.mariadb_username
password = local.mariadb_password password = local.mariadb_password
parameter_group_name = aws_db_parameter_group.mariadb_parameter_group.name parameter_group_name = aws_db_parameter_group.mariadb_parameter_group.name
storage_encrypted = true storage_encrypted = true
publicly_accessible = true publicly_accessible = true
port = local.mariadb_port port = local.mariadb_port
skip_final_snapshot = true skip_final_snapshot = true
} }
# MariaDB Parameter Group # MariaDB Parameter Group
resource "aws_db_parameter_group" "mariadb_parameter_group" { resource "aws_db_parameter_group" "mariadb_parameter_group" {
name = "mariadb-parameter-group" name = "mariadb-parameter-group"
family = "mariadb10.11" family = "mariadb10.11"
parameter { parameter {
▲ Show 20 Lines • Show All 56 Lines • Show Last 20 Lines