Page MenuHomePhabricator

[lib] Check the timestamps when joining threads
ClosedPublic

Authored by tomek on Sep 2 2024, 4:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 11:07 PM
Unknown Object (File)
Sat, Nov 9, 4:55 PM
Unknown Object (File)
Thu, Nov 7, 8:08 PM
Unknown Object (File)
Thu, Nov 7, 8:01 PM
Unknown Object (File)
Thu, Nov 7, 7:57 PM
Unknown Object (File)
Thu, Nov 7, 5:43 PM
Unknown Object (File)
Sun, Nov 3, 8:32 PM
Unknown Object (File)
Sun, Nov 3, 8:31 PM
Subscribers

Details

Summary

Only update the membership when the operation is younger than the saved timestamp.

https://linear.app/comm/issue/ENG-9115/update-jointhreadspec

Depends on D13216

Test Plan

Created two join thread operations and made sure the timestamp is set correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lib/shared/dm-ops/join-thread-spec.js
174 ↗(On Diff #43825)

There was a bug that caused an operation to be queued when a viewer was joining a thread.

tomek requested review of this revision.Sep 2 2024, 5:01 AM
inka added inline comments.
lib/shared/dm-ops/join-thread-spec.js
73 ↗(On Diff #43829)

Same as in the previous diff we should probably handle timestamp collision

This revision is now accepted and ready to land.Sep 3 2024, 3:43 AM