Page MenuHomePhabricator
Differential D13218

[lib] Check the timestamps when adding the viewer to thread members
ClosedPublic
Actions

Authored by tomek on Sep 2 2024, 7:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 7:40 AM
Unknown Object (File)
Fri, Apr 18, 11:29 AM
Unknown Object (File)
Fri, Apr 18, 5:06 AM
Unknown Object (File)
Thu, Apr 17, 7:54 PM
Unknown Object (File)
Thu, Apr 17, 7:12 PM
Unknown Object (File)
Thu, Apr 17, 9:15 AM
Unknown Object (File)
Sat, Apr 12, 10:35 PM
Unknown Object (File)
Thu, Apr 10, 3:41 PM
View All 84 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMM2a7c9bc65f1a: [lib] Check the timestamps when adding the viewer to thread members
Summary

Check the timestamp and update the membership only when necessary.

https://linear.app/comm/issue/ENG-9114/update-addviewertothreadmembersspec

Depends on D13217

Test Plan

Created two add_viewer_to_thread_members operations and checked if the resulting timestamps are correct (all the timestamps should equal the first operation time except the membership.role timestamp).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Sep 2 2024, 7:15 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 2 2024, 7:15 AM
tomek updated this revision to Diff 43830.Sep 2 2024, 7:23 AM

Rebase

Harbormaster completed remote builds in B31381: Diff 43826.Sep 2 2024, 7:32 AM
tomek added a child revision: D13219: [lib] Include `timestamps` inside `CreateThickRawThreadInfoInput`.Sep 2 2024, 7:41 AM
Harbormaster completed remote builds in B31385: Diff 43830.Sep 2 2024, 7:41 AM
tomek requested review of this revision.Sep 2 2024, 7:41 AM
inka added inline comments.Sep 3 2024, 3:50 AM
lib/shared/dm-ops/add-viewer-to-thread-members-spec.js
76 ↗(On Diff #43830)

Same as in previous diffs, we should probably handle timestamp collisions

90–117 ↗(On Diff #43830)

Why don't we make createThickRawThreadInfo take timestamps?

tomek added inline comments.Sep 5 2024, 3:15 AM
lib/shared/dm-ops/add-viewer-to-thread-members-spec.js
76 ↗(On Diff #43830)

https://linear.app/comm/issue/ENG-9159/thick-threads-timestamps-conflict-resolution

90–117 ↗(On Diff #43830)

In the next diff D13219 I add this parameter. I'm going to update this spec in that diff.

inka accepted this revision.Sep 5 2024, 6:41 AM
This revision is now accepted and ready to land.Sep 5 2024, 6:41 AM
Closed by commit rCOMM2a7c9bc65f1a: [lib] Check the timestamps when adding the viewer to thread members (authored by tomek). · Explain WhySep 6 2024, 8:10 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM2a7c9bc65f1a: [lib] Check the timestamps when adding the viewer to thread members.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
13 lines
131 lines

Diff 43934

View Options

lib/shared/dm-ops/add-members-spec.js

Show All 19 Linesexport const siweBackupDataValidator: TInterface<SIWEBackupData> =
}); });
// This type should match `LatestBackupInfo` in // This type should match `LatestBackupInfo` in
// `native/native_rust_library/src/backup.rs` // `native/native_rust_library/src/backup.rs`
export type LatestBackupInfo = { export type LatestBackupInfo = {
+backupID: string, +backupID: string,
+userID: string, +userID: string,
+siweBackupData?: ?SIWEBackupData, +siweBackupData?: ?SIWEBackupData,
+keyserverDeviceID?: ?string,
}; };
export const latestBackupInfoResponseValidator: TInterface<LatestBackupInfo> = export const latestBackupInfoResponseValidator: TInterface<LatestBackupInfo> =
tShape<LatestBackupInfo>({ tShape<LatestBackupInfo>({
backupID: t.String, backupID: t.String,
userID: t.String, userID: t.String,
siweBackupData: t.maybe(siweBackupDataValidator), siweBackupData: t.maybe(siweBackupDataValidator),
keyserverDeviceID: t.maybe(t.String),
}); });
// This type should match `UserKeys` in // This type should match `UserKeys` in
// `native/native_rust_library/src/backup.rs` // `native/native_rust_library/src/backup.rs`
export type UserKeys = { export type UserKeys = {
+backupDataKey: string, +backupDataKey: string,
+backupLogDataKey: string, +backupLogDataKey: string,
+pickleKey: string, +pickleKey: string,
Show All 19 Lines
View Options

lib/shared/dm-ops/add-viewer-to-thread-members-spec.js

Show All 19 Linesexport const siweBackupDataValidator: TInterface<SIWEBackupData> =
}); });
// This type should match `LatestBackupInfo` in // This type should match `LatestBackupInfo` in
// `native/native_rust_library/src/backup.rs` // `native/native_rust_library/src/backup.rs`
export type LatestBackupInfo = { export type LatestBackupInfo = {
+backupID: string, +backupID: string,
+userID: string, +userID: string,
+siweBackupData?: ?SIWEBackupData, +siweBackupData?: ?SIWEBackupData,
+keyserverDeviceID?: ?string,
}; };
export const latestBackupInfoResponseValidator: TInterface<LatestBackupInfo> = export const latestBackupInfoResponseValidator: TInterface<LatestBackupInfo> =
tShape<LatestBackupInfo>({ tShape<LatestBackupInfo>({
backupID: t.String, backupID: t.String,
userID: t.String, userID: t.String,
siweBackupData: t.maybe(siweBackupDataValidator), siweBackupData: t.maybe(siweBackupDataValidator),
keyserverDeviceID: t.maybe(t.String),
}); });
// This type should match `UserKeys` in // This type should match `UserKeys` in
// `native/native_rust_library/src/backup.rs` // `native/native_rust_library/src/backup.rs`
export type UserKeys = { export type UserKeys = {
+backupDataKey: string, +backupDataKey: string,
+backupLogDataKey: string, +backupLogDataKey: string,
+pickleKey: string, +pickleKey: string,
Show All 19 Lines