Page MenuHomePhabricator
Differential D13217

[lib] Check the timestamps when joining threads
ClosedPublic
Actions

Authored by tomek on Sep 2 2024, 4:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 6:08 AM
Unknown Object (File)
Sat, Nov 9, 11:07 PM
Unknown Object (File)
Sat, Nov 9, 4:55 PM
Unknown Object (File)
Thu, Nov 7, 8:08 PM
Unknown Object (File)
Thu, Nov 7, 8:01 PM
Unknown Object (File)
Thu, Nov 7, 7:57 PM
Unknown Object (File)
Thu, Nov 7, 5:43 PM
Unknown Object (File)
Sun, Nov 3, 8:32 PM
View All 60 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMM1fa0f3e873ce: [lib] Check the timestamps when joining threads
Summary

Only update the membership when the operation is younger than the saved timestamp.

https://linear.app/comm/issue/ENG-9115/update-jointhreadspec

Depends on D13216

Test Plan

Created two join thread operations and made sure the timestamp is set correctly.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Sep 2 2024, 4:45 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 2 2024, 4:45 AM
tomek added inline comments.Sep 2 2024, 4:46 AM
lib/shared/dm-ops/join-thread-spec.js
174 ↗(On Diff #43825)

There was a bug that caused an operation to be queued when a viewer was joining a thread.

Harbormaster completed remote builds in B31380: Diff 43825.Sep 2 2024, 5:01 AM
tomek requested review of this revision.Sep 2 2024, 5:01 AM
tomek added a child revision: D13218: [lib] Check the timestamps when adding the viewer to thread members.Sep 2 2024, 7:15 AM
tomek updated this revision to Diff 43829.Sep 2 2024, 7:22 AM

Rebase

Harbormaster completed remote builds in B31384: Diff 43829.Sep 2 2024, 7:39 AM
inka accepted this revision.Sep 3 2024, 3:43 AM
inka added inline comments.
lib/shared/dm-ops/join-thread-spec.js
73

Same as in the previous diff we should probably handle timestamp collision

This revision is now accepted and ready to land.Sep 3 2024, 3:43 AM
tomek added inline comments.Sep 5 2024, 3:12 AM
lib/shared/dm-ops/join-thread-spec.js
73

https://linear.app/comm/issue/ENG-9159/thick-threads-timestamps-conflict-resolution

Closed by commit rCOMM1fa0f3e873ce: [lib] Check the timestamps when joining threads (authored by tomek). · Explain WhySep 6 2024, 8:10 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM1fa0f3e873ce: [lib] Check the timestamps when joining threads.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
57 lines

Diff 43829

View Options

lib/shared/dm-ops/join-thread-spec.js

Loading...