Page MenuHomePhabricator

[identity] Verify lastPrimarySignature for singleton lists
ClosedPublic

Authored by bartek on Mon, Sep 2, 11:25 PM.
Tags
None
Referenced Files
F2751074: D13222.id43844.diff
Wed, Sep 18, 2:13 PM
F2746963: D13222.id43984.diff
Wed, Sep 18, 8:30 AM
F2745978: D13222.id43846.diff
Wed, Sep 18, 7:01 AM
F2744920: D13222.id43844.diff
Wed, Sep 18, 5:03 AM
F2737723: D13222.diff
Tue, Sep 17, 7:23 PM
Unknown Object (File)
Sun, Sep 15, 10:48 PM
Unknown Object (File)
Sun, Sep 15, 10:36 PM
Unknown Object (File)
Sun, Sep 15, 4:37 PM
Subscribers

Details

Summary

Required for ENG-8212.
In case of backup restore, the singleton device list will also have lastPrimarySignature, which wasn't accepted before for singleton device lists.

Test Plan

Existing tests still pass.
Tested manually with lastPrimarySignature being present:

  • Passes with no last primary signature provided and none expected (previous behavior unchanged)
  • Fails if signature provided but none expected
  • Fails no signature is provided but one is expected
  • Passes if valid signature is provided and it's expected (previous signing key provided)
  • Fails if signature verification fails for given signing public key

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Tue, Sep 3, 12:04 AM
This revision is now accepted and ready to land.Fri, Sep 6, 5:43 AM