Paths

Table of Contentst

Differential D13347

[lib] check timestamps before processing edit entry operation
ClosedPublic
Actions

Authored by will on Sep 16 2024, 1:31 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 2, 4:32 AM

	Unknown Object (File)
	Sat, Nov 2, 4:32 AM

	Unknown Object (File)
	Sat, Nov 2, 4:32 AM

	Unknown Object (File)
	Sat, Nov 2, 4:32 AM

	Unknown Object (File)
	Sat, Nov 2, 4:31 AM

	Unknown Object (File)
	Wed, Oct 23, 9:12 AM

	Unknown Object (File)
	Tue, Oct 22, 1:18 PM

	Unknown Object (File)
	Tue, Oct 22, 10:22 AM

View All 46 Files

Subscribers

None

Details

Reviewers

tomek
marcin
ashoat

Commits

rCOMM1a9f981e4063: [lib] check timestamps before processing edit entry operation

Summary

This checks the timestamp to ensure that an edit operation produces a no-op update if produced with a timestamp before latest updated time

Follows logic from https://phab.comm.dev/D13215

Depends on D13346

Test Plan

Not sure how to test this yet. Might manually run these with different timestamps? Unsure how I might be able to introduce a delay.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Sep 16 2024, 1:31 AM

will added a child revision: D13348: [lib] check timestamps before processing delete entry operation.

Harbormaster completed remote builds in B31629: Diff 44201.Sep 16 2024, 2:05 AM

will requested review of this revision.Sep 16 2024, 2:05 AM

will mentioned this in D13341: [lib] DMOperationSpec for edit entry operation.Sep 16 2024, 5:40 AM

tomek accepted this revision.Sep 16 2024, 5:46 AM

tomek added inline comments.

lib/shared/dm-ops/edit-entry-spec.js
46 ↗	(On Diff #44201)	It would be easier if we kept this property name consistent between all the operations.
66 ↗	(On Diff #44201)	Can we early exit when this condition isn't met? We should return only `rawMessageInfos` with empty `updateInfos` in such a case.

This revision is now accepted and ready to land.Sep 16 2024, 5:46 AM

remove unnecesssary Thick thread type import

Harbormaster completed remote builds in B31654: Diff 44242.Sep 16 2024, 2:25 PM

Closed by commit rCOMM1a9f981e4063: [lib] check timestamps before processing edit entry operation (authored by will). · Explain WhySep 16 2024, 2:27 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM1a9f981e4063: [lib] check timestamps before processing edit entry operation.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

edit-entry-spec.js

24 lines

Diff 44254

lib/shared/dm-ops/edit-entry-spec.js

Loading...