Page MenuHomePhabricator

[keyserver][lib] Update raw entry info to be thick or thin
ClosedPublic

Authored by will on Sep 12 2024, 10:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 31, 2:22 AM
Unknown Object (File)
Tue, Oct 29, 3:46 PM
Unknown Object (File)
Mon, Oct 28, 3:49 PM
Unknown Object (File)
Wed, Oct 23, 5:32 PM
Unknown Object (File)
Sun, Oct 20, 2:57 PM
Unknown Object (File)
Sun, Oct 20, 2:57 PM
Unknown Object (File)
Sun, Oct 20, 2:57 PM
Unknown Object (File)
Sun, Oct 20, 2:57 PM
Subscribers
None

Details

Summary

This updates raw entry info to be union type of either thick or thin.

Test Plan

flow check. Will test later in stack

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will requested review of this revision.Sep 12 2024, 10:43 PM
tomek added inline comments.
lib/types/entry-types.js
37 ↗(On Diff #44115)

Should this be mandatory for thick threads?

51–53 ↗(On Diff #44115)
63 ↗(On Diff #44115)

Looks like it is always true.

This revision is now accepted and ready to land.Sep 13 2024, 3:02 AM
lib/types/entry-types.js
37 ↗(On Diff #44115)

Agree – we can move this out of the base, and have it be t.maybe for thin and always defined for thick

38 ↗(On Diff #44115)

Do we need localID for thick?

63 ↗(On Diff #44115)

We can use tBool(true)

lib/types/entry-types.js
38 ↗(On Diff #44115)

Seemingly not? We seemingly use it for optimistic creations before it gets assigned a serverID on the keyserver. I imagine this doesn't really apply in client to client?

lib/types/entry-types.js
26 ↗(On Diff #44236)

I thought we agreed we didn't need this in the base

37 ↗(On Diff #44236)

I thought we agreed we didn't need this in the base