Page MenuHomePhabricator
Differential D13348

[lib] check timestamps before processing delete entry operation
ClosedPublic
Actions

Authored by will on Mon, Sep 16, 1:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 16, 2:00 PM
Unknown Object (File)
Mon, Sep 16, 1:59 PM
Unknown Object (File)
Mon, Sep 16, 1:56 PM
Subscribers
None

Details

Reviewers
marcin
ashoat
tomek
Commits
rCOMM24e495a0bb66: [lib] check timestamps before processing delete entry operation
Summary

Checks timestamps to unsure delete operation isn't alread out of date. If it is, produces a no-op update.

Depends on D13347

Test Plan

As previous, unsure yet how to test this. Will update test plan later

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Mon, Sep 16, 1:33 AM
will added a child revision: D13349: [web] disable history button on web on clicking entry.
Harbormaster completed remote builds in B31630: Diff 44202.Mon, Sep 16, 2:09 AM
will requested review of this revision.Mon, Sep 16, 2:09 AM
will mentioned this in D13340: [lib] DMOperationSpec for delete entry operation.Mon, Sep 16, 5:41 AM
tomek accepted this revision.Mon, Sep 16, 5:49 AM
tomek added inline comments.
lib/shared/dm-ops/delete-entry-spec.js
64–65 ↗(On Diff #44202)

Can we exit early if this condition isn't met and use the same property name (time) consistently for all the operations?

This revision is now accepted and ready to land.Mon, Sep 16, 5:49 AM
Closed by commit rCOMM24e495a0bb66: [lib] check timestamps before processing delete entry operation (authored by will). · Explain WhyMon, Sep 16, 2:27 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM24e495a0bb66: [lib] check timestamps before processing delete entry operation.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
23 lines

Diff 44253

View Options

lib/shared/dm-ops/delete-entry-spec.js

Loading...