Page MenuHomePhabricator
Differential D13343

[lib][native][web] send encrypted dms on web and native for create entry
ClosedPublic
Actions

Authored by will on Sep 16 2024, 1:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 9:18 PM
Unknown Object (File)
Fri, Feb 28, 5:46 AM
Unknown Object (File)
Fri, Feb 28, 5:46 AM
Unknown Object (File)
Fri, Feb 28, 5:46 AM
Unknown Object (File)
Fri, Feb 28, 5:46 AM
Unknown Object (File)
Mon, Feb 24, 5:04 AM
Unknown Object (File)
Jan 31 2025, 7:46 PM
Unknown Object (File)
Jan 23 2025, 5:16 PM
View All 71 Files
Subscribers
None

Details

Reviewers
marcin
ashoat
tomek
kamil
Commits
rCOMM928274b4547c: [lib][native][web] send encrypted dms on web and native for create entry
Summary

When entries are created in thick threads, this updates the create entry hook to use e2ee dm operations instead of the keyserver

Depends on D13341

Test Plan

Keyserver create entries still work the same. Opened two web browsers, two iOS simulators and created entries on each one with two accounts different accounts per platform.
Ensured that entries appeared on all 4. They appeared without much delay

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Sep 16 2024, 1:22 AM
will added a child revision: D13344: [lib][native][web] send encrypted dms on web and native when editing entries on thick threads.Sep 16 2024, 1:24 AM
will added a child revision: D13345: [lib][native][web] send encrypted dms on web and native when deleting on thick threads.Sep 16 2024, 1:39 AM
will removed a child revision: D13345: [lib][native][web] send encrypted dms on web and native when deleting on thick threads.
Harbormaster completed remote builds in B31625: Diff 44197.Sep 16 2024, 1:45 AM
will requested review of this revision.Sep 16 2024, 1:45 AM
tomek accepted this revision.Sep 16 2024, 5:09 AM
tomek added a reviewer: kamil.
tomek added inline comments.
lib/actions/entry-actions.js
232 ↗(On Diff #44197)

createEntryInfo contains a timestamp - what does it mean? Should we use it somewhere?

kamil accepted this revision.Sep 16 2024, 8:16 AM
kamil added inline comments.
lib/actions/entry-actions.js
249 ↗(On Diff #44197)
This revision is now accepted and ready to land.Sep 16 2024, 8:16 AM
will edited the summary of this revision. (Show Details)Sep 16 2024, 8:32 AM
will added a parent revision: D13341: [lib] DMOperationSpec for edit entry operation.
will removed a parent revision: D13342: lib] DMOperationSpec for restore entry operation.
will updated this revision to Diff 44237.Sep 16 2024, 1:33 PM
will edited the summary of this revision. (Show Details)

review feedback

Harbormaster completed remote builds in B31649: Diff 44237.Sep 16 2024, 1:53 PM
Closed by commit rCOMM928274b4547c: [lib][native][web] send encrypted dms on web and native for create entry (authored by will). · Explain WhySep 16 2024, 2:27 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM928274b4547c: [lib][native][web] send encrypted dms on web and native for create entry.

Revision Contents
Changeset List

PathSize
lib/
actions/
83 lines
native/
calendar/
23 lines
web/
calendar/
22 lines

Diff 44249

View Options

lib/actions/entry-actions.js

Show All 36 Lines
import { extractUserIDsFromPayload } from '../../utils/conversion-utils.js'; import { extractUserIDsFromPayload } from '../../utils/conversion-utils.js';
import { useSelector, useDispatch } from '../../utils/redux-utils.js'; import { useSelector, useDispatch } from '../../utils/redux-utils.js';
import { messageSpecs } from '../messages/message-specs.js'; import { messageSpecs } from '../messages/message-specs.js';
import { updateSpecs } from '../updates/update-specs.js'; import { updateSpecs } from '../updates/update-specs.js';
function useSendDMOperationUtils(): ProcessDMOperationUtilities { function useSendDMOperationUtils(): ProcessDMOperationUtilities {
const fetchMessage = useGetLatestMessageEdit(); const fetchMessage = useGetLatestMessageEdit();
const threadInfos = useSelector(state => state.threadStore.threadInfos); const threadInfos = useSelector(state => state.threadStore.threadInfos);
const entryInfos = useSelector(state => state.entryStore.entryInfos);
return React.useMemo( return React.useMemo(
() => ({ () => ({
fetchMessage, fetchMessage,
threadInfos, threadInfos,
entryInfos,
}), }),
[fetchMessage, threadInfos], [fetchMessage, threadInfos, entryInfos],
); );
} }
function useProcessDMOperation(): ( function useProcessDMOperation(): (
dmOperationSpecification: DMOperationSpecification, dmOperationSpecification: DMOperationSpecification,
dmOpID: ?string, dmOpID: ?string,
) => Promise<void> { ) => Promise<void> {
const threadInfos = useSelector(state => state.threadStore.threadInfos); const threadInfos = useSelector(state => state.threadStore.threadInfos);
▲ Show 20 Lines • Show All 344 Lines • Show Last 20 Lines
View Options

native/calendar/entry.react.js

Show All 36 Lines
import { extractUserIDsFromPayload } from '../../utils/conversion-utils.js'; import { extractUserIDsFromPayload } from '../../utils/conversion-utils.js';
import { useSelector, useDispatch } from '../../utils/redux-utils.js'; import { useSelector, useDispatch } from '../../utils/redux-utils.js';
import { messageSpecs } from '../messages/message-specs.js'; import { messageSpecs } from '../messages/message-specs.js';
import { updateSpecs } from '../updates/update-specs.js'; import { updateSpecs } from '../updates/update-specs.js';
function useSendDMOperationUtils(): ProcessDMOperationUtilities { function useSendDMOperationUtils(): ProcessDMOperationUtilities {
const fetchMessage = useGetLatestMessageEdit(); const fetchMessage = useGetLatestMessageEdit();
const threadInfos = useSelector(state => state.threadStore.threadInfos); const threadInfos = useSelector(state => state.threadStore.threadInfos);
const entryInfos = useSelector(state => state.entryStore.entryInfos);
return React.useMemo( return React.useMemo(
() => ({ () => ({
fetchMessage, fetchMessage,
threadInfos, threadInfos,
entryInfos,
}), }),
[fetchMessage, threadInfos], [fetchMessage, threadInfos, entryInfos],
); );
} }
function useProcessDMOperation(): ( function useProcessDMOperation(): (
dmOperationSpecification: DMOperationSpecification, dmOperationSpecification: DMOperationSpecification,
dmOpID: ?string, dmOpID: ?string,
) => Promise<void> { ) => Promise<void> {
const threadInfos = useSelector(state => state.threadStore.threadInfos); const threadInfos = useSelector(state => state.threadStore.threadInfos);
▲ Show 20 Lines • Show All 344 Lines • Show Last 20 Lines
View Options

web/calendar/entry.react.js

Show All 36 Lines
import { extractUserIDsFromPayload } from '../../utils/conversion-utils.js'; import { extractUserIDsFromPayload } from '../../utils/conversion-utils.js';
import { useSelector, useDispatch } from '../../utils/redux-utils.js'; import { useSelector, useDispatch } from '../../utils/redux-utils.js';
import { messageSpecs } from '../messages/message-specs.js'; import { messageSpecs } from '../messages/message-specs.js';
import { updateSpecs } from '../updates/update-specs.js'; import { updateSpecs } from '../updates/update-specs.js';
function useSendDMOperationUtils(): ProcessDMOperationUtilities { function useSendDMOperationUtils(): ProcessDMOperationUtilities {
const fetchMessage = useGetLatestMessageEdit(); const fetchMessage = useGetLatestMessageEdit();
const threadInfos = useSelector(state => state.threadStore.threadInfos); const threadInfos = useSelector(state => state.threadStore.threadInfos);
const entryInfos = useSelector(state => state.entryStore.entryInfos);
return React.useMemo( return React.useMemo(
() => ({ () => ({
fetchMessage, fetchMessage,
threadInfos, threadInfos,
entryInfos,
}), }),
[fetchMessage, threadInfos], [fetchMessage, threadInfos, entryInfos],
); );
} }
function useProcessDMOperation(): ( function useProcessDMOperation(): (
dmOperationSpecification: DMOperationSpecification, dmOperationSpecification: DMOperationSpecification,
dmOpID: ?string, dmOpID: ?string,
) => Promise<void> { ) => Promise<void> {
const threadInfos = useSelector(state => state.threadStore.threadInfos); const threadInfos = useSelector(state => state.threadStore.threadInfos);
▲ Show 20 Lines • Show All 344 Lines • Show Last 20 Lines