Page MenuHomePhabricator
Differential D13349

[web] disable history button on web on clicking entry
ClosedPublic
Actions

Authored by will on Mon, Sep 16, 1:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 17, 2:10 PM
Unknown Object (File)
Tue, Sep 17, 1:19 PM
Unknown Object (File)
Tue, Sep 17, 8:12 AM
Unknown Object (File)
Mon, Sep 16, 2:00 PM
Unknown Object (File)
Mon, Sep 16, 1:59 PM
Unknown Object (File)
Mon, Sep 16, 1:56 PM
Subscribers
None

Details

Reviewers
tomek
ashoat
marcin
Commits
rCOMM7b68beb6c9d3: [web] disable history button on web on clicking entry
Summary

This disables the history button when clicking a given entry if thick threaded on web. Disabling the history button for a day box will be introduced in a separate diff

Depends on D13348

Test Plan

Checked on local web app. history button no longer appears

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Mon, Sep 16, 1:34 AM
will added a child revision: D13350: [native][web] use tunnelbroker for online status of thick threaded entries instead of keyserver.
Harbormaster completed remote builds in B31631: Diff 44203.Mon, Sep 16, 2:14 AM
will requested review of this revision.Mon, Sep 16, 2:14 AM
tomek accepted this revision.Mon, Sep 16, 5:50 AM

Let's document this somewhere. Also, it might be a good idea to introduce a single flag for it.

This revision is now accepted and ready to land.Mon, Sep 16, 5:50 AM
ashoat added a comment.Mon, Sep 16, 1:04 PM

Where would we document? Maybe @tomek was thinking of something like a function function isCalendarEntryHistoryEnabled(threadType: ThreadType): boolean

ashoat mentioned this in D13354: [web] Disable thick thread entries from showing up in the history modal as history entries.Mon, Sep 16, 1:23 PM
Closed by commit rCOMM7b68beb6c9d3: [web] disable history button on web on clicking entry (authored by will). · Explain WhyMon, Sep 16, 2:27 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM7b68beb6c9d3: [web] disable history button on web on clicking entry.
tomek added a comment.Tue, Sep 17, 1:01 AM
In D13349#376126, @ashoat wrote:

Where would we document? Maybe @tomek was thinking of something like a function function isCalendarEntryHistoryEnabled(threadType: ThreadType): boolean

Ah, I should've added more details. I was thinking about creating a task that tracks introducing the history of thick thread entries and removing a flag (or a function).

Revision Contents
Changeset List

PathSize
web/
calendar/
5 lines

Diff 44255

View Options

web/calendar/entry.react.js

Loading...