[lib] Create Redux store for blob holders
ClosedPublic
Actions

Authored by bartek on Sep 20 2024, 3:47 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMMc714711fe073: [lib] Create Redux store for blob holders

Summary

Address ENG-9280.
Created a store for blob holders

Created initial version of the holder store. Inspired by D12936

Test Plan

Native and web:

Logged out and in before applying this diff. Stayed logged in.
Applied this diff
Restarted app to make sure the migration was successful

Native log:

LOG  redux-persist: migrationKeys [83]
LOG  redux-persist: running migration for versionKey 83
LOG  redux-persist/stateReconciler: rehydrated keys 'navInfo, currentUserInfo, entryStore, messageStore, calendarFilters, dataLoaded, customServer, alertStore, watchedThreadIDs, enabledApps, reportStore, globalThemeInfo, deviceCameraInfo, userPolicies, keyserverStore, localSettings, threadActivityStore, communityStore, tunnelbrokerDeviceToken, queuedDMOperations, _persist, holderStore'

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Sep 20 2024, 3:47 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 20 2024, 3:47 AM

bartek added a child revision: D13403: [lib] Add reducer and action to store established holder.Sep 20 2024, 3:52 AM

Harbormaster completed remote builds in B31730: Diff 44360.Sep 20 2024, 4:04 AM

bartek published this revision for review.Sep 20 2024, 4:20 AM

Can you link the task for adding this store to SQLite? We should absolutely not be adding new O(n) to redux-persist, so this work needs to be sequenced pretty much immediately (eg. this month, or early next month). cc @kamil

kamil accepted this revision.Sep 20 2024, 5:55 AM

This revision is now accepted and ready to land.Sep 20 2024, 5:55 AM

In D13402#377228, @ashoat wrote:

Can you link the task for adding this store to SQLite? We should absolutely not be adding new O(n) to redux-persist, so this work needs to be sequenced pretty much immediately (eg. this month, or early next month). cc @kamil

Agree - looks like it's mentioned here.

Closed by commit rCOMMc714711fe073: [lib] Create Redux store for blob holders (authored by bartek). · Explain WhySep 23 2024, 7:24 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMc714711fe073: [lib] Create Redux store for blob holders.