Page MenuHomePhabricator
Differential D13407

[lib] Add blob fields to DMOperationResult
AcceptedPublic
Actions

Authored by bartek on Fri, Sep 20, 6:13 AM.
Tags
None
Referenced Files
F2781709: D13407.diff
Fri, Sep 20, 3:22 PM
F2779484: D13407.id44366.diff
Fri, Sep 20, 11:39 AM
F2779274: D13407.id44366.diff
Fri, Sep 20, 10:08 AM
F2779255: D13407.id.diff
Fri, Sep 20, 10:07 AM
F2779233: D13407.diff
Fri, Sep 20, 10:06 AM
F2778065: D13407.diff
Fri, Sep 20, 7:32 AM
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Summary

This will be needed for ENG-9288.
DM ops will return blob hashes that need establishing / removing their holders.

Test Plan

Flow. Logic added in further diffs

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Fri, Sep 20, 6:13 AM
bartek held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Sep 20, 6:13 AM
bartek added a child revision: D13411: [lib] Process blob holders in DM ops.Fri, Sep 20, 6:30 AM
Harbormaster completed remote builds in B31736: Diff 44366.Fri, Sep 20, 6:30 AM
bartek published this revision for review.Fri, Sep 20, 6:42 AM
kamil accepted this revision.Fri, Sep 20, 7:40 AM
kamil added inline comments.
lib/types/dm-ops.js
490–493

you need to add $ReadOnly< {} > - spreading remove this property

This revision is now accepted and ready to land.Fri, Sep 20, 7:40 AM

Revision Contents
Changeset List

Diff 44366

View Options

lib/shared/dm-ops/add-members-spec.js

Loading...
View Options

lib/shared/dm-ops/add-viewer-to-thread-members-spec.js

Loading...
View Options

lib/shared/dm-ops/change-thread-read-status-spec.js

Loading...
View Options

lib/shared/dm-ops/change-thread-settings-spec.js

Loading...
View Options

lib/shared/dm-ops/change-thread-subscription.js

Loading...
View Options

lib/shared/dm-ops/create-entry-spec.js

Loading...
View Options

lib/shared/dm-ops/create-sidebar-spec.js

Loading...
View Options

lib/shared/dm-ops/create-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/delete-entry-spec.js

Loading...
View Options

lib/shared/dm-ops/edit-entry-spec.js

Loading...
View Options

lib/shared/dm-ops/join-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/leave-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/remove-members-spec.js

Loading...
View Options

lib/shared/dm-ops/send-edit-message-spec.js

Loading...
View Options

lib/shared/dm-ops/send-multimedia-message-spec.js

Loading...
View Options

lib/shared/dm-ops/send-reaction-message-spec.js

Loading...
View Options

lib/shared/dm-ops/send-text-message-spec.js

Loading...
View Options

lib/types/dm-ops.js

Loading...
View Options

lib/types/holder-types.js

Loading...