Page MenuHomePhabricator
Differential D13407

[lib] Add blob fields to DMOperationResult
ClosedPublic
Actions

Authored by bartek on Sep 20 2024, 6:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 10:36 AM
Unknown Object (File)
Wed, Nov 20, 10:35 AM
Unknown Object (File)
Wed, Nov 20, 10:35 AM
Unknown Object (File)
Wed, Nov 20, 10:35 AM
Unknown Object (File)
Fri, Nov 1, 5:37 AM
Unknown Object (File)
Wed, Oct 30, 11:27 PM
Unknown Object (File)
Wed, Oct 30, 11:27 PM
Unknown Object (File)
Wed, Oct 30, 11:26 PM
View All 54 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMM889673b897af: [lib] Add blob fields to DMOperationResult
Summary

This will be needed for ENG-9288.
DM ops will return blob hashes that need establishing / removing their holders.

Test Plan

Flow. Logic added in further diffs

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Sep 20 2024, 6:13 AM
bartek held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptSep 20 2024, 6:13 AM
bartek added a child revision: D13411: [lib] Process blob holders in DM ops.Sep 20 2024, 6:30 AM
Harbormaster completed remote builds in B31736: Diff 44366.Sep 20 2024, 6:30 AM
bartek published this revision for review.Sep 20 2024, 6:42 AM
kamil accepted this revision.Sep 20 2024, 7:40 AM
kamil added inline comments.
lib/types/dm-ops.js
490–493 ↗(On Diff #44366)

you need to add $ReadOnly< {} > - spreading remove this property

This revision is now accepted and ready to land.Sep 20 2024, 7:40 AM
bartek updated this revision to Diff 44411.Sep 23 2024, 4:03 AM

Add ReadOnly

Harbormaster completed remote builds in B31765: Diff 44411.Sep 23 2024, 4:21 AM
Closed by commit rCOMM889673b897af: [lib] Add blob fields to DMOperationResult (authored by bartek). · Explain WhySep 23 2024, 7:24 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM889673b897af: [lib] Add blob fields to DMOperationResult.

Revision Contents
Changeset List

Diff 44429

View Options

lib/shared/dm-ops/add-members-spec.js

Loading...
View Options

lib/shared/dm-ops/add-viewer-to-thread-members-spec.js

Loading...
View Options

lib/shared/dm-ops/change-thread-read-status-spec.js

Loading...
View Options

lib/shared/dm-ops/change-thread-settings-spec.js

Loading...
View Options

lib/shared/dm-ops/change-thread-subscription.js

Loading...
View Options

lib/shared/dm-ops/create-entry-spec.js

Loading...
View Options

lib/shared/dm-ops/create-sidebar-spec.js

Loading...
View Options

lib/shared/dm-ops/create-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/delete-entry-spec.js

Loading...
View Options

lib/shared/dm-ops/edit-entry-spec.js

Loading...
View Options

lib/shared/dm-ops/join-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/leave-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/remove-members-spec.js

Loading...
View Options

lib/shared/dm-ops/send-edit-message-spec.js

Loading...
View Options

lib/shared/dm-ops/send-multimedia-message-spec.js

Loading...
View Options

lib/shared/dm-ops/send-reaction-message-spec.js

Loading...
View Options

lib/shared/dm-ops/send-text-message-spec.js

Loading...
View Options

lib/shared/dm-ops/update-relationship-spec.js

Loading...
View Options

lib/types/dm-ops.js

Loading...
View Options

lib/types/holder-types.js

Loading...