[lib] Prefix blob holders with device ID
ClosedPublic
Actions

Authored by bartek on Sep 20 2024, 9:58 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMM924d5c321656: [lib] Prefix blob holders with device ID

Summary

Address ENG-9282.
Made multimedia blob holders prefixed by device ID.

Device ID is a base64-like string, which isn't a valid holder so used base64url conversion.

Test Plan

Successfully uploaded multimedia to a DM thread. Printed the

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Sep 20 2024, 9:58 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 20 2024, 9:58 AM

Harbormaster completed remote builds in B31729: Diff 44359.Sep 20 2024, 10:15 AM

bartek added a child revision: D13403: [lib] Add reducer and action to store established holder.Sep 20 2024, 10:52 AM

bartek published this revision for review.Sep 20 2024, 10:53 AM

kamil accepted this revision.Sep 20 2024, 1:00 PM

This revision is now accepted and ready to land.Sep 20 2024, 1:00 PM

bartek mentioned this in D13410: [lib] Let blob holder generator take deviceID as argument.Sep 20 2024, 1:25 PM

Closed by commit rCOMM924d5c321656: [lib] Prefix blob holders with device ID. · Explain WhySep 23 2024, 2:24 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM924d5c321656: [lib] Prefix blob holders with device ID.

bartek mentioned this in rCOMMa5b81199539a: [lib] Let blob holder generator take deviceID as argument.

bartek mentioned this in D15315: [blob] Improve tags support.Sep 11 2025, 8:40 AM

bartek mentioned this in rCOMMa84d6fc72c49: [blob] Improve tags support.Sep 13 2025, 1:34 PM

Revision Contents
Changeset List

Path

Size

lib/

actions/

upload-actions.js

3 lines

utils/

blob-service.js

18 lines

Diff 44426

View Options

lib/actions/upload-actions.js