Page MenuHomePhabricator
Differential D13401

[lib] Prefix blob holders with device ID
ClosedPublic
Actions

Authored by bartek on Sep 20 2024, 2:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 3:35 PM
Unknown Object (File)
Thu, Apr 3, 10:41 AM
Unknown Object (File)
Thu, Apr 3, 6:38 AM
Unknown Object (File)
Wed, Apr 2, 3:25 AM
Unknown Object (File)
Thu, Mar 27, 5:34 PM
Unknown Object (File)
Sun, Mar 16, 1:02 PM
Unknown Object (File)
Mar 6 2025, 2:19 AM
Unknown Object (File)
Feb 28 2025, 9:26 AM
View All 57 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMM924d5c321656: [lib] Prefix blob holders with device ID
Summary

Address ENG-9282.
Made multimedia blob holders prefixed by device ID.

Device ID is a base64-like string, which isn't a valid holder so used base64url conversion.

Test Plan

Successfully uploaded multimedia to a DM thread. Printed the

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
actions/
3 lines
utils/
18 lines

Diff 44426

View Options

lib/actions/upload-actions.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
parseThreadPermissionString, parseThreadPermissionString,
constructThreadPermissionString,
includeThreadPermissionForThreadType, includeThreadPermissionForThreadType,
} from './prefixes.js'; } from './prefixes.js';
import { import {
configurableCommunityPermissions, configurableCommunityPermissions,
threadPermissionFilterPrefixes, threadPermissionFilterPrefixes,
threadPermissionPropagationPrefixes, threadPermissionPropagationPrefixes,
threadPermissions, threadPermissions,
userSurfacedPermissions, userSurfacedPermissions,
▲ Show 20 Lines • Show All 148 Lines • ▼ Show 20 Lines if (!parsed.propagationPrefix) {
continue; continue;
} }
if ( if (
parsed.propagationPrefix === parsed.propagationPrefix ===
threadPermissionPropagationPrefixes.DESCENDANT threadPermissionPropagationPrefixes.DESCENDANT
) { ) {
permissionsForChildren[permissionKey] = permissionValue; permissionsForChildren[permissionKey] = permissionValue;
} }
const permissionWithFilterPrefix = parsed.filterPrefix const withoutPropagationPrefix = constructThreadPermissionString({
? `${parsed.filterPrefix}${parsed.permission}` ...parsed,
: parsed.permission; propagationPrefix: null,
permissionsForChildren[permissionWithFilterPrefix] = permissionValue; });
permissionsForChildren[withoutPropagationPrefix] = permissionValue;
} }
if (Object.keys(permissionsForChildren).length === 0) { if (Object.keys(permissionsForChildren).length === 0) {
return null; return null;
} }
return permissionsForChildren; return permissionsForChildren;
} }
function getRoleForPermissions( function getRoleForPermissions(
▲ Show 20 Lines • Show All 373 Lines • Show Last 20 Lines
View Options

lib/utils/blob-service.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
parseThreadPermissionString, parseThreadPermissionString,
constructThreadPermissionString,
includeThreadPermissionForThreadType, includeThreadPermissionForThreadType,
} from './prefixes.js'; } from './prefixes.js';
import { import {
configurableCommunityPermissions, configurableCommunityPermissions,
threadPermissionFilterPrefixes, threadPermissionFilterPrefixes,
threadPermissionPropagationPrefixes, threadPermissionPropagationPrefixes,
threadPermissions, threadPermissions,
userSurfacedPermissions, userSurfacedPermissions,
▲ Show 20 Lines • Show All 148 Lines • ▼ Show 20 Lines if (!parsed.propagationPrefix) {
continue; continue;
} }
if ( if (
parsed.propagationPrefix === parsed.propagationPrefix ===
threadPermissionPropagationPrefixes.DESCENDANT threadPermissionPropagationPrefixes.DESCENDANT
) { ) {
permissionsForChildren[permissionKey] = permissionValue; permissionsForChildren[permissionKey] = permissionValue;
} }
const permissionWithFilterPrefix = parsed.filterPrefix const withoutPropagationPrefix = constructThreadPermissionString({
? `${parsed.filterPrefix}${parsed.permission}` ...parsed,
: parsed.permission; propagationPrefix: null,
permissionsForChildren[permissionWithFilterPrefix] = permissionValue; });
permissionsForChildren[withoutPropagationPrefix] = permissionValue;
} }
if (Object.keys(permissionsForChildren).length === 0) { if (Object.keys(permissionsForChildren).length === 0) {
return null; return null;
} }
return permissionsForChildren; return permissionsForChildren;
} }
function getRoleForPermissions( function getRoleForPermissions(
▲ Show 20 Lines • Show All 373 Lines • Show Last 20 Lines