Page MenuHomePhabricator

[lib] Create holder ops for thick thread avatars
ClosedPublic

Authored by bartek on Sep 20 2024, 6:42 AM.
Tags
None
Referenced Files
F3206531: D13413.id44384.diff
Sun, Nov 10, 1:06 AM
F3200884: D13413.id44381.diff
Sat, Nov 9, 2:55 PM
Unknown Object (File)
Fri, Nov 8, 11:45 AM
Unknown Object (File)
Fri, Nov 1, 5:34 AM
Unknown Object (File)
Wed, Oct 30, 11:28 PM
Unknown Object (File)
Wed, Oct 30, 11:28 PM
Unknown Object (File)
Wed, Oct 30, 11:28 PM
Unknown Object (File)
Wed, Oct 30, 11:17 PM
Subscribers

Details

Summary

Added blob holder operations when changing thick thread avatars.

We want to:

  • Always remove a holder if the old avatar was image
  • Establish holder if the new avatar is image. We want it only for inbound ops. For outbound, the holder is already established during image upload.

Depends on D13411

Test Plan

Created a DM thread with two devices.

  • Set avatar to image on device A. Only device B generated op to establish holder.
  • Changed avatar to another image. Both devices generated op to remove avatar. Only inbound device established holder.
  • Reset avatar to emoji. Both devices removed their avatars

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Sep 20 2024, 7:09 AM
This revision is now accepted and ready to land.Sep 23 2024, 12:37 AM