Page MenuHomePhabricator

[lib] Create holder ops for thick thread avatars
ClosedPublic

Authored by bartek on Sep 20 2024, 6:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 10:35 AM
Unknown Object (File)
Wed, Nov 20, 10:35 AM
Unknown Object (File)
Tue, Nov 12, 10:50 PM
Unknown Object (File)
Tue, Nov 12, 5:55 AM
Unknown Object (File)
Tue, Nov 12, 5:51 AM
Unknown Object (File)
Mon, Nov 11, 5:33 PM
Unknown Object (File)
Mon, Nov 11, 8:44 AM
Unknown Object (File)
Sun, Nov 10, 11:24 PM
Subscribers

Details

Summary

Added blob holder operations when changing thick thread avatars.

We want to:

  • Always remove a holder if the old avatar was image
  • Establish holder if the new avatar is image. We want it only for inbound ops. For outbound, the holder is already established during image upload.

Depends on D13411

Test Plan

Created a DM thread with two devices.

  • Set avatar to image on device A. Only device B generated op to establish holder.
  • Changed avatar to another image. Both devices generated op to remove avatar. Only inbound device established holder.
  • Reset avatar to emoji. Both devices removed their avatars

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Sep 20 2024, 7:09 AM
This revision is now accepted and ready to land.Sep 23 2024, 12:37 AM