Page MenuHomePhabricator
Differential D13415

[lib] Establish holders for DM multimedia
ClosedPublic
Actions

Authored by bartek on Sep 20 2024, 7:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 28, 3:05 PM
Unknown Object (File)
Sun, Mar 16, 12:12 AM
Unknown Object (File)
Feb 28 2025, 7:16 PM
Unknown Object (File)
Feb 28 2025, 9:26 AM
Unknown Object (File)
Feb 28 2025, 8:12 AM
Unknown Object (File)
Feb 24 2025, 8:27 PM
Unknown Object (File)
Feb 6 2025, 10:39 AM
Unknown Object (File)
Feb 6 2025, 5:25 AM
View All 53 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMM46dbd248a088: [lib] Establish holders for DM multimedia
Summary

When receiving DM multimedia message (inbound), we should establish holders for the media.
Sender (outbound) has them already established during media upload.

Depends on D13413

Test Plan

Created DM thread with two users. Sent a photo and a video. No holders were established for sender.
Recipients established 3 holders: photo, video and video thumbnail.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
41 lines

Diff 44435

View Options

lib/shared/dm-ops/send-multimedia-message-spec.js

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines +getInboundKeysForUserDevice: (
authDeviceId: string, authDeviceId: string,
authAccessToken: string, authAccessToken: string,
userId: string, userId: string,
deviceId: string, deviceId: string,
) => Promise<InboundKeyInfoResponse>, ) => Promise<InboundKeyInfoResponse>,
+getFarcasterUsers: ( +getFarcasterUsers: (
farcasterIds: $ReadOnlyArray<string>, farcasterIds: $ReadOnlyArray<string>,
) => Promise<$ReadOnlyArray<FarcasterUser>>, ) => Promise<$ReadOnlyArray<FarcasterUser>>,
+generateNonce: () => Promise<string>,
}; };
export type { RustNativeBindingAPI }; export type { RustNativeBindingAPI };