Differential D13415

[lib] Establish holders for DM multimedia
ClosedPublic
Actions

Authored by bartek on Sep 20 2024, 7:39 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Feb 6, 10:39 AM

	Unknown Object (File)
	Thu, Feb 6, 5:25 AM

	Unknown Object (File)
	Thu, Jan 30, 1:08 PM

	Unknown Object (File)
	Thu, Jan 30, 1:08 PM

	Unknown Object (File)
	Dec 28 2024, 5:05 AM

	Unknown Object (File)
	Dec 28 2024, 5:05 AM

	Unknown Object (File)
	Dec 28 2024, 5:04 AM

	Unknown Object (File)
	Dec 28 2024, 5:04 AM

View All 47 Files

Subscribers

Details

Reviewers

kamil
tomek

Commits

rCOMM46dbd248a088: [lib] Establish holders for DM multimedia

Summary

When receiving DM multimedia message (inbound), we should establish holders for the media.
Sender (outbound) has them already established during media upload.

Depends on D13413

Test Plan

Created DM thread with two users. Sent a photo and a video. No holders were established for sender.
Recipients established 3 holders: photo, video and video thumbnail.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Sep 20 2024, 7:39 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 20 2024, 7:39 AM

bartek published this revision for review.Sep 20 2024, 7:49 AM

Harbormaster completed remote builds in B31751: Diff 44389.Sep 20 2024, 7:57 AM

kamil accepted this revision.Sep 23 2024, 12:39 AM

This revision is now accepted and ready to land.Sep 23 2024, 12:39 AM

Closed by commit rCOMM46dbd248a088: [lib] Establish holders for DM multimedia (authored by bartek). · Explain WhySep 23 2024, 7:25 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM46dbd248a088: [lib] Establish holders for DM multimedia.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

send-multimedia-message-spec.js

41 lines

Diff 44389

lib/shared/dm-ops/send-multimedia-message-spec.js

Loading...