Paths

Table of Contentst

[blob] Use new blob-exists check in single endpoint
ClosedPublic
Actions

Authored by bartek on Sep 26 2024, 7:40 AM.

Details

Reviewers

will
varun
kamil
marcin

Commits

rCOMM8ce683c9558f: [blob] Use new blob-exists check in single endpoint

Summary

Despite D13481, multiple GetItem DDB calls were still happening inside service.assign_holder(). Removed that call there and updated single endpoint to use the new way.

Updated single assign-holder endpoint to use the new batch function.

Depends on D13481

Test Plan

Made sure data_exists has still correct value for the POST /blob endpoint
Blob integration tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Sep 26 2024, 7:40 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 26 2024, 7:40 AM

Harbormaster completed remote builds in B31869: Diff 44587.Sep 26 2024, 8:00 AM

bartek published this revision for review.Sep 26 2024, 8:00 AM

kamil accepted this revision.Sep 27 2024, 9:47 AM

This revision is now accepted and ready to land.Sep 27 2024, 9:47 AM

Closed by commit rCOMM8ce683c9558f: [blob] Use new blob-exists check in single endpoint. · Explain WhySep 27 2024, 1:55 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM8ce683c9558f: [blob] Use new blob-exists check in single endpoint.

bartek mentioned this in D13510: [terraform] Bump staging Blob to 1.2.0.Sep 28 2024, 8:22 AM

bartek mentioned this in rCOMM2aa6b1a9e611: [terraform] Bump staging Blob to 1.2.0.Sep 30 2024, 7:29 AM

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

http/

handlers/

blob.rs

13 lines

holders.rs

5 lines

service.rs

7 lines

Diff 44634

View Options

services/blob/src/http/handlers/blob.rs

View Options

services/blob/src/http/handlers/holders.rs

View Options

services/blob/src/service.rs

[blob] Use new blob-exists check in single endpointClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44634

services/blob/src/http/handlers/blob.rs

services/blob/src/http/handlers/holders.rs

services/blob/src/service.rs

[blob] Use new blob-exists check in single endpoint
ClosedPublic
Actions

Revision Contents
Changeset List