Address ENG-4842.
Request and response format described in the Linear issue.
Created a new DELETE /holders endpoint for removing multiple holders in a single request.
Details
Details
Ran Blob locally. Called the endpoint using Postman and made sure holders are removed from DDB.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/blob/src/http/handlers/holders.rs | ||
|---|---|---|
| 46 ↗ | (On Diff #44583) | This has to be done sequentially in a loop because service.revoke_holder() makes a DDB transaction and these transactions could conflict with each other, e.g. if two holders were removed for the same blob hash. It is theoretically possible to make it one transaction but it's complicated and not worth doing as long as performance is okay |
| services/blob/src/http/handlers/holders.rs | ||
|---|---|---|
| 46 ↗ | (On Diff #44583) | worth adding as code comment |