[lib] Don't display notFriendNotice for the viewer
ClosedPublic
Actions

Authored by ashoat on Sep 30 2024, 9:56 PM.

Details

Reviewers

tomek
kamil
inka

Commits

rCOMM31793e3ec987: [lib] Don't display notFriendNotice for the viewer

Summary

Prior to the changes in D13540, usePotentialMemberItems never got the viewer as an input, so it didn't need to consider it.

It currently sets notFriendNotice for the viewer, which doesn't make sense. While it's true that the viewer is not a friend with themselves, we have no reason to display that notice to the user.

Depends on D13541

Test Plan

Confirm that notFriendNotice no longer appears for the viewer (the viewer's entry in the list of users that can be added to the chat)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 30 2024, 9:56 PM

ashoat added a child revision: D13543: [native][web] Only show viewer in chat composer results when empty.Sep 30 2024, 10:00 PM

Harbormaster completed remote builds in B31958: Diff 44723.Sep 30 2024, 10:43 PM

ashoat requested review of this revision.Sep 30 2024, 10:43 PM

tomek accepted this revision.Oct 1 2024, 6:07 AM

This revision is now accepted and ready to land.Oct 1 2024, 6:07 AM

Closed by commit rCOMM31793e3ec987: [lib] Don't display notFriendNotice for the viewer (authored by ashoat). · Explain WhyOct 1 2024, 9:07 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM31793e3ec987: [lib] Don't display notFriendNotice for the viewer.

Revision Contents
Changeset List

Path

Size

lib/

shared/

search-utils.js

12 lines

Diff 44772

View Options

lib/shared/search-utils.js

[lib] Don't display notFriendNotice for the viewerClosedPublicActions