Page MenuHomePhabricator
Differential D13542

[lib] Don't display notFriendNotice for the viewer
ClosedPublic
Actions

Authored by ashoat on Sep 30 2024, 9:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 11:53 AM
Unknown Object (File)
Wed, Dec 18, 11:53 AM
Unknown Object (File)
Wed, Dec 18, 11:52 AM
Unknown Object (File)
Wed, Dec 18, 11:52 AM
Unknown Object (File)
Sun, Nov 24, 10:37 PM
Unknown Object (File)
Nov 21 2024, 8:51 PM
Unknown Object (File)
Nov 10 2024, 4:20 PM
Unknown Object (File)
Nov 8 2024, 3:01 AM
View All 38 Files
Subscribers
None

Details

Reviewers
tomek
kamil
inka
Commits
rCOMM31793e3ec987: [lib] Don't display notFriendNotice for the viewer
Summary

Prior to the changes in D13540, usePotentialMemberItems never got the viewer as an input, so it didn't need to consider it.

It currently sets notFriendNotice for the viewer, which doesn't make sense. While it's true that the viewer is not a friend with themselves, we have no reason to display that notice to the user.

Depends on D13541

Test Plan

Confirm that notFriendNotice no longer appears for the viewer (the viewer's entry in the list of users that can be added to the chat)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
12 lines

Diff 44772

View Options

lib/shared/search-utils.js

Loading...